Review main Merged

83679[BUGFIX] Working link to word details in indexed_search

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 04/08/24, 06:41

Commit message

The indexed_search BE module links to word details.
This link is broken in main and v12:

* In main, the wordHash argument is a string, but the extbase
  target action expects an int.
* In v12, the wordHash is an int, but is misinterpreted as
  pages-uid.

The patch fixes this by switching from the argument name
'id' to 'wordHash' to suppress the pages-uid "convention"
to kick in. In main, the target action argument is declared
as string and both arguments are set non-optional.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 2

Review log 79

  1. Christian Kuhn uploaded patch set 1 04/07/24, 06:16

  2. core-ci voted on patch set 1 V +1 04/07/24, 06:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55488

  3. Christian Kuhn updated the commit message in patch set 2 V +1 04/07/24, 06:22

  4. core-ci voted on patch set 2 V +1 04/07/24, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55489

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 04/07/24, 09:53

  6. Andreas Kienast voted on patch set 2 CR +1 V +1 04/07/24, 15:13

  7. Benni Mack voted on patch set 2 CR +1 V +1 04/07/24, 21:38

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 04/08/24, 06:41

  9. Christian Kuhn merged patch set 3 04/08/24, 06:41