Review main Merged

83681[BUGFIX] t3editor: Keep original flex configuration

Andreas Kienast CR +2 V +2 Easy +0 −12 updated 04/07/24, 10:03

Commit message

When t3editor got streamlined in the past, configuration for flex was
defined that conflicts with CodeMirror's internal style definition,
leading to UI glitches like "cut out" content, see screenshot attached
to the ticket..

This commit removes the conflicting CSS.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Torben Hansen +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Torben Hansen +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Andreas Kienast uploaded patch set 1 04/07/24, 06:26

  2. core-ci voted on patch set 1 V +1 04/07/24, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55492

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 04/07/24, 07:17

    Fixes the issue for me, thanks! Maybe change the title to "[BUGFIX] t3editor: Keep original flex layout to prevent missing display" or "[BUGFIX] Prevent t3editor not displaying parts of content"
  4. Stefan Bürk voted on patch set 1 CR +1 V +1 04/07/24, 07:43

  5. Christian Kuhn commented on patch set 1 CR +1 V +1 04/07/24, 08:00

    thx! this drove me nuts for quite a while already!
  6. Torben Hansen voted on patch set 1 CR +1 V +1 04/07/24, 08:58

  7. Andreas Kienast voted on patch set 1 CR +2 V +2 04/07/24, 10:03

  8. Andreas Kienast merged patch set 2 04/07/24, 10:03