Review main Merged

83686[TASK] Avoid two useless hooks in ext:lowlevel

Christian Kuhn CR +2 V +2 Easy +0 −13 updated 04/08/24, 07:03

Commit message

There is an ancient, hidden and not documented hook
in ext:lowlevel since "ever":
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['t3lib_fullsearch']
used with "beforeResultTable" and "additionalButtons".

Both calls are useless: "beforeResultTable" does not
receive any useful information except $this->MOD_SETTINGS
(which changed multiple times already without further
notice), and "additionalButtons" only receives the current
row. There is no further code to act on anything
"additionalButtons" may have added.

Considering this is within ext:lowlevel "only", only in the
complex "DB check" module, and a TER search reveals not a
single use ever, it seems to be fair to remove this code
without further notice since it very most likely has
zero impact to anyone.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 04/07/24, 10:02

  2. core-ci voted on patch set 1 V +1 04/07/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55499

  3. Andreas Kienast voted on patch set 1 CR +1 04/07/24, 15:13

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 04/07/24, 15:35

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 04/08/24, 06:59

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 04/08/24, 07:03

  7. Christian Kuhn merged patch set 2 04/08/24, 07:03