Review main Merged

83687[TASK] Avoid indexed_search lexer debug

Christian Kuhn CR +2 V +2 Easy +1 −34 updated 04/08/24, 06:46

Commit message

The indexed_search class Lexer is used to split strings
into words using some weird multibyte magic.

It has a "debug" mode, enabled during indexing when
ext_conf_template.txt debugMode is true. It then creates
a HTML string in its main split2Words() method, which is
later written to index_debug along with other
debug information. That debug string is then output in
the BE module when looking at indexing details, if given.

The fun part is, this debug string is reset in-between
multiple split2Words() calls, and any indexing always calls
the method four times, with the last one being 'description',
which is usually empty.

This means there is in practice almost never any debug
output to show in BE, and even if shown, it is only a
fraction of the processed content.

The patch removes this lexer debug handling.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 67

  1. Christian Kuhn uploaded patch set 1 04/07/24, 11:17

  2. core-ci voted on patch set 1 V +1 04/07/24, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55502

  3. Stefan Bürk voted on patch set 1 CR +1 04/07/24, 12:12

  4. Stefan Bürk voted on patch set 1 V +1 04/07/24, 12:18

  5. Andreas Kienast voted on patch set 1 CR +1 V +1 04/07/24, 16:29

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 04/08/24, 06:46

  7. Christian Kuhn merged patch set 2 04/08/24, 06:46