83690[TASK] Add `npm` command dispatcher to `Build/Scripts/runTests.sh`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Thomas Hohn +1
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 1
Review log 67
-
Stefan Bürk uploaded patch set 1 04/07/24, 12:03
-
core-ci voted on patch set 1 V +1 04/07/24, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55506
-
Garvin Hicking commented on patch set 1 CR +1 V +1 04/07/24, 17:06
Works well for me, tested on: Darwin MBP-M1Pro2021-16G 23.4.0 Darwin Kernel Version 23.4.0: Wed Feb 21 21:44:43 PST 2024; root:xnu-10063.101.15~2/RELEASE_ARM64_T6000 arm64 (Sonoma 14.4) I ran the ci, build and watch tasks. Since the watch tasks AFAIR are not based on inotify but can do other processing too, it works also across the docker boundary for macOS. -
Thomas Hohn voted on patch set 1 CR +1 04/08/24, 08:07
-
Christian Kuhn voted on patch set 1 CR +1 V +1 04/08/24, 09:00
-
Stefan Bürk voted on patch set 1 CR +2 V +2 04/08/24, 10:37
-
Stefan Bürk merged patch set 2 04/08/24, 10:53