Review main Merged

83693[BUGFIX] Avoid calling non-existing method on `NullSite`

Stefan Bürk CR +2 V +2 Easy +2 −1 updated 04/07/24, 17:26

Commit message

`\TYPO3\CMS\Core\Site\Entity\Site::isTypoScriptRoot()`
has been added with #103437 without adding it to the
`\TYPO3\CMS\Core\Site\Entity\NullSite` class and the
`\TYPO3\CMS\Core\Site\Entity\SiteInterface` and used
in `PageInformationFactory::setSysTemplateRows()`.

Calling this method requires that the concrete Site
implementation needs to be guaranteed, which is not
done with introduced usage with #103439 in method
`PageInformationFactory::setSysTemplateRows()`.

This change adds now a interface check to call the
method only on concrete `Site` entity objects.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 810

  1. Stefan Bürk uploaded patch set 1 04/07/24, 14:57

  2. core-ci voted on patch set 1 V +1 04/07/24, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55510

  3. Stefan Bürk uploaded patch set 2 V +1 04/07/24, 15:18

  4. Andreas Kienast voted on patch set 2 CR +1 04/07/24, 15:24

  5. core-ci voted on patch set 2 V +1 04/07/24, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55512

  6. Oliver Klee voted on patch set 2 CR +1 04/07/24, 15:50

  7. Andreas Kienast voted on patch set 2 V +1 04/07/24, 16:16

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 04/07/24, 17:25

  9. Stefan Bürk voted on patch set 2 CR +2 V +2 04/07/24, 17:26

  10. Stefan Bürk merged patch set 3 04/07/24, 17:26