83694[TASK] Add `RedirectService` tests as preparation for a bugfix
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 5
- Task #103555Add `RedirectService` tests as preparation for a bugfix
- Bug #103395Redirects with domains without site configuration not possible anymore
- Bug #103554Avoid calling non-existing method on `NullSite`
- Task #103439Site TypoScript
- Feature #103437Site Sets that ship Settings, TypoScript, TSConfig, Templates and enabled Content Elements
Files 7
- typo3/sysext/redirects/Tests/Functional/Fixtures/Extensions/test_bolt/Classes/EventListener/AddTypoScriptFromSiteExtensionEventListener.phpnew+151 −0
- typo3/sysext/redirects/Tests/Functional/Fixtures/Extensions/test_bolt/Configuration/Services.yamlnew+14 −0
- typo3/sysext/redirects/Tests/Functional/Fixtures/Extensions/test_bolt/composer.jsonnew+20 −0
- typo3/sysext/redirects/Tests/Functional/Fixtures/Extensions/test_bolt/ext_emconf.phpnew+21 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/SourceHostWithoutSourceConfigRedirect.csvnew+8 −0
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+93 −0
- composer.json+1 −0
Review log 812
-
Stefan Bürk uploaded patch set 1 04/07/24, 15:12
-
core-ci voted on patch set 1 V -1 04/07/24, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55511
-
Stefan Bürk rebased onto patch set 2
V -104/07/24, 15:18 -
Stefan Bürk uploaded patch set 3 04/07/24, 15:20
-
core-ci voted on patch set 2 V -1 04/07/24, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55513
-
core-ci voted on patch set 3 V +1 04/07/24, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55514
-
Stefan Bürk uploaded patch set 4
V +104/07/24, 17:43 -
core-ci voted on patch set 4 V +1 04/07/24, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55516
-
Garvin Hicking voted on patch set 4 CR +1 V +1 04/07/24, 17:53
-
Georg Ringer voted on patch set 4 CR +1 V +1 04/07/24, 19:39
-
Stefan Bürk voted on patch set 4 CR +2 V +2 04/07/24, 20:35
-
Stefan Bürk merged patch set 5 04/07/24, 20:55