83698[BUGFIX] Fix array access error in EditableRestriction
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1518
-
Sybille Peters uploaded patch set 1 04/08/24, 05:01
-
Sybille Peters wrote 04/08/24, 05:02
Topic set to Linkvalidator -
core-ci voted on patch set 1 V -1 04/08/24, 05:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55530
-
Sybille Peters uploaded patch set 2
V -104/08/24, 05:15 -
core-ci voted on patch set 2 V +1 04/08/24, 05:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55532
-
Jörg Bösche voted on patch set 2 CR +1 04/08/24, 07:54
-
Christian Kuhn voted on patch set 2 CR +1 04/08/24, 09:02
-
Georg Ringer voted on patch set 2 CR +1 V +1 06/10/24, 13:18
-
Garvin Hicking commented on patch set 2 06/10/24, 13:24
EditableRestriction.php:68Check for "if ($fieldConfig === [])" here to clarify fallback intent, instead of falsy comparison? -
Andreas Kienast uploaded patch set 3
CR +1V +106/10/24, 13:37 -
Andreas Kienast commented on patch set 3 06/10/24, 13:37
EditableRestriction.php:68ReplyDone -
core-ci voted on patch set 3 V +1 06/10/24, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59013
-
Sybille Peters commented on patch set 2 06/10/24, 13:43
EditableRestriction.php:68ReplyIs this how it is generally done in the core or is this a question / suggestion? Can you point me to a source where it is explained, because I don't really understand the advantage? -
Andreas Kienast commented on patch set 3 06/10/24, 14:21
EditableRestriction.php:68ReplyIt's more explicit, we usually want to avoid "too wide" comparisons. -
Sybille Peters commented on patch set 3 06/10/24, 15:55
EditableRestriction.php:68ReplyMarking as resolved, has been changed. Thanks. -
Benni Mack commented on patch set 3 CR +1 V +1 06/21/24, 09:47
will hopefully be solved with Schema API soon -
Christian Kuhn voted on patch set 3 CR +2 V +2 06/21/24, 12:10
-
Benni Mack merged patch set 4 06/21/24, 12:21