Review main Merged

83700[TASK] Use more DI in indexed_search

Christian Kuhn CR +2 V +2 Normal +96 −137 updated 04/08/24, 13:02

Commit message

Switch a couple of classes to use more DI.

Note class Lexer was instantiated with a 'poor man'
and oldschool approach similar to XCLASS before, which
is now switched to DI. This is not considered breaking
since all involved classes are marked `@internal`,
there is not a single TER extension that actually
uses this 'EXTCONF' based Lexer override, the class
does not even have a proper interface, and any
override most likely broke with previous v13 patches
already.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 911

  1. Christian Kuhn uploaded patch set 1 04/08/24, 08:35

  2. core-ci voted on patch set 1 V +1 04/08/24, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55541

  3. Christian Kuhn updated the commit message in patch set 2 V +1 04/08/24, 08:52

  4. core-ci voted on patch set 2 V +1 04/08/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55543

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 04/08/24, 09:47

  6. Andreas Kienast voted on patch set 2 CR +1 04/08/24, 10:40

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 04/08/24, 10:53

  8. Oliver Klee voted on patch set 2 CR +1 04/08/24, 10:56

  9. Andreas Kienast voted on patch set 2 V +1 04/08/24, 13:01

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 04/08/24, 13:02

  11. Christian Kuhn merged patch set 3 04/08/24, 13:02