Review main Merged

83703[TASK] Add additional tests for `RedirectService` handling

Stefan Bürk CR +2 V +2 Easy +34 −0 updated 04/08/24, 14:02

Commit message

This change adds additional tests to cover additional
variants for `EXT:redirects` handling. Placing guards
helps to avoid mitigating regressions for these cases.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 67

  1. Stefan Bürk uploaded patch set 1 04/08/24, 11:08

  2. core-ci voted on patch set 1 V +1 04/08/24, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55553

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 04/08/24, 13:39

  4. Oliver Klee voted on patch set 1 CR +1 V +1 04/08/24, 13:44

  5. Stefan Bürk commented on patch set 1 CR -1 04/08/24, 13:49

    Thanks - will merge after https://review.typo3.org/c/Packages/TYPO3.CMS/+/83701 has been merged, otherwise the backport would fail.
  6. Stefan Bürk voted on patch set 1 CR +2 V +2 04/08/24, 13:52

  7. Stefan Bürk merged patch set 2 04/08/24, 14:02