Review main Merged

83704[TASK] Remove `HtmlParser->caseShift()`

Andreas Kienast CR +2 V +2 Normal +20 −38 updated 04/08/24, 13:38

Commit message

The method `HtmlParser->caseShift()` is used to normalize the casing of
values that are about to get compared, depending on whether a
case-sensitive comparison is wanted at all which isn't, by default [1].

Also, the method had a runtime cache that doesn't have a great benefit.
Therefore, the method is removed and normalization is done at the former
method calls.

[1] https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/HtmlparserTags.html#fixattrib-attribute-casesensitivecomp

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Andreas Kienast uploaded patch set 1 04/08/24, 11:21

  2. Andreas Kienast uploaded patch set 2 04/08/24, 11:23

  3. core-ci voted on patch set 1 V +1 04/08/24, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55554

  4. core-ci voted on patch set 2 V +1 04/08/24, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55555

  5. Andreas Kienast uploaded patch set 3 V +1 04/08/24, 11:35

  6. core-ci voted on patch set 3 V +1 04/08/24, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55556

  7. Christian Kuhn voted on patch set 3 CR +1 V +1 04/08/24, 11:43

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 04/08/24, 13:25

  9. Christian Kuhn commented on patch set 3 04/08/24, 13:38

    note this makes the class stateless ;)
  10. Christian Kuhn voted on patch set 3 CR +2 V +2 04/08/24, 13:38

  11. Christian Kuhn merged patch set 4 04/08/24, 13:38