83705[TASK] Modernize RootlineUtility and tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/core/Classes/Utility/RootlineUtility.php2+25 −34
- typo3/sysext/core/Tests/Functional/Utility/File/Fixtures/DataSet/sys_file.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Utility/File/Fixtures/DataSet/sys_refindex.csvrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Utility/File/Fixtures/Folders/FolderWithUnusedFile/unused.txtrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Utility/File/Fixtures/Folders/FolderWithUsedFile/used.txtrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Utility/File/ExtendedFileUtilityTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Utility/Fixtures/RootlineScenario.yamldeleted+0 −58
- typo3/sysext/core/Tests/Functional/Utility/Fixtures/RootlineUtilityImport.csvnew+26 −0
- typo3/sysext/core/Tests/Functional/Utility/RootlineUtilityTest.php+319 −82
- typo3/sysext/core/Tests/Unit/Utility/RootlineUtilityTest.phpdeleted+0 −291
Review log 1115
-
Christian Kuhn uploaded patch set 1 04/08/24, 12:33
-
core-ci voted on patch set 1 V +1 04/08/24, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55558
-
Christian Kuhn uploaded patch set 2
V +104/08/24, 12:40 -
core-ci voted on patch set 2 V +1 04/08/24, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55559
-
Christian Kuhn updated the commit message in patch set 3
V +104/08/24, 12:53 -
Christian Kuhn updated the commit message in patch set 4 04/08/24, 12:54
-
core-ci voted on patch set 3 V +1 04/08/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55560
-
core-ci voted on patch set 4 V +1 04/08/24, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55561
-
Oliver Klee commented on patch set 4 V +1 04/08/24, 13:06
-
Christian Kuhn commented on patch set 4 04/08/24, 13:12
RootlineUtility.php:159Replyinteresting. i've not been aware of that, yet. this will require a global patch at multiple places when we prepare towards php 8.4. let's do it in one go at this point in time. note the patch does not change the method signature (except protecting it), it only moves the method down a bit, to have get() as main api-method directly behind __construct(). -
Oliver Klee voted on patch set 4 CR +1 04/08/24, 13:18
-
Stefan Bürk voted on patch set 4 CR +1 V +1 04/08/24, 13:39
-
Andreas Kienast voted on patch set 4 CR +1 V +1 04/08/24, 13:46
-
Christian Kuhn voted on patch set 4 CR +2 V +2 04/08/24, 13:46
-
Christian Kuhn merged patch set 5 04/08/24, 13:47
RootlineUtility.php:159