Review main Merged

83705[TASK] Modernize RootlineUtility and tests

Christian Kuhn CR +2 V +2 Hard +373 −468 updated 04/08/24, 13:47

Commit message

RootlineUtility is *the* performance bottleneck
in FE. But we have a cunning plan for improvements :)

The patch streamlines some details to prepare things.

RootlineUtility:
* Protect getCacheIdentifier() and isMountedPage(),
  which were only public to unit test them.
* Throw an exception if TCA pages columns is not
  set, which would indicate a serious misuse in
  early bootstrap.
* Simplify minor details.

Tests:
* Merge remaining unit tests into functional tests.
* Switch from YAML based DB scenario creation to
  direct CSV import to gain more control in tests.
* Test reference index integrity of import CSV. Spoiler
  alert: This will become more important later.
* Move some not related fixtures to a more suitable
  directory.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1115

  1. Christian Kuhn uploaded patch set 1 04/08/24, 12:33

  2. core-ci voted on patch set 1 V +1 04/08/24, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55558

  3. Christian Kuhn uploaded patch set 2 V +1 04/08/24, 12:40

  4. core-ci voted on patch set 2 V +1 04/08/24, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55559

  5. Christian Kuhn updated the commit message in patch set 3 V +1 04/08/24, 12:53

  6. Christian Kuhn updated the commit message in patch set 4 04/08/24, 12:54

  7. core-ci voted on patch set 3 V +1 04/08/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55560

  8. core-ci voted on patch set 4 V +1 04/08/24, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55561

  9. Oliver Klee commented on patch set 4 V +1 04/08/24, 13:06

    RootlineUtility.php:159

    `$otherUid` should be nullable to ensure compatibility with upcoming PHP versions. https://php.watch/rfcs/deprecate-implicitly-nullable-types
  10. Christian Kuhn commented on patch set 4 04/08/24, 13:12

    RootlineUtility.php:159 Reply

    interesting. i've not been aware of that, yet. this will require a global patch at multiple places when we prepare towards php 8.4. let's do it in one go at this point in time. note the patch does not change the method signature (except protecting it), it only moves the method down a bit, to have get() as main api-method directly behind __construct().
  11. Oliver Klee voted on patch set 4 CR +1 04/08/24, 13:18

  12. Stefan Bürk voted on patch set 4 CR +1 V +1 04/08/24, 13:39

  13. Andreas Kienast voted on patch set 4 CR +1 V +1 04/08/24, 13:46

  14. Christian Kuhn voted on patch set 4 CR +2 V +2 04/08/24, 13:46

  15. Christian Kuhn merged patch set 5 04/08/24, 13:47