83707[BUGFIX] Set default value for extbase Container::$prototypeObjects...
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Stefan Bürk +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1317
-
Christian Weiske uploaded patch set 1 04/08/24, 13:39
-
core-ci voted on patch set 1 V +1 04/08/24, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55564
-
Oliver Klee updated the commit message in patch set 2
V +104/08/24, 14:18 -
Oliver Klee commented on patch set 2 04/08/24, 14:19
Have you checked if main and 12.4 are affected as well (in addition to 11.5)? If so, the workflow is to create the change for main first and then have the mergers do the backports. -
Stefan Bürk commented on patch set 1 04/08/24, 14:20
Change is okay, but the commit message is not correct. Container::getInstance() is only called from Extbase ObjectManager, and removed along with the ObjectManager in TYPO3 v12. Using this chain, the property is ensured. The error comes from the getEmptyObject() chain which does not follow that chain and never did. Since PHP8.0+ this is now an issue but has been undetected. The hint about DI and Singleton(Interface) and the call of getInstance() is literally wrong. SingleonInterface never defined to provide a `getInstance()` method and therefore could not be safely called. The interface was a marker so the instance is used in a "shared" manner (which DI is per default until `shared: false` is defined for a service). Having the patch for v11 only is okay, as the mentioned class does not exists in never version. Can you please adjust the commit message, so it contains a valid statement ? -
core-ci voted on patch set 2 V -1 04/08/24, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55568
-
Christian Weiske updated the commit message in patch set 3
V -104/09/24, 05:19 -
Christian Weiske commented on patch set 3 04/09/24, 05:19
Reply
Done -
core-ci voted on patch set 3 V -1 04/09/24, 05:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55587
-
Christian Weiske commented on patch set 3 04/09/24, 06:48
I don't know why CI fails, while there are no code changes to the first patch version. -
core-ci voted on patch set 3 V +1 04/09/24, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55587
-
Oliver Klee voted on patch set 3 CR +1 V +1 04/09/24, 07:14
-
Oliver Klee voted on patch set 3 V 0 04/09/24, 07:14
-
Andreas Kienast voted on patch set 3 CR +1 V +1 04/10/24, 07:22
-
Stefan Bürk voted on patch set 3 CR +1 V +1 04/10/24, 07:31
-
Stefan Bürk voted on patch set 3 CR +2 V +2 04/10/24, 07:33
-
Stefan Bürk merged patch set 4 04/10/24, 07:33