83709[FEATURE] Provide site and language context in FLUIDTEMPLATE
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 57
-
Benjamin Franzke uploaded patch set 1 04/08/24, 15:01
-
core-ci voted on patch set 1 V -1 04/08/24, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55571
-
Benni Mack commented on patch set 1 04/08/24, 15:12
This is really difficult, as site and language might be taken already. -
Benjamin Franzke commented on patch set 1 CR -2 04/08/24, 15:51
Just figured this is not needed at all. We really should use getText in FLUIDTEMPLATE https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/Data.html#data-type-site https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/Data.html#data-type-siteSettingsReply
fyi: They would not be overriden, but overlayed by custom variables or data processed. -
Benjamin Kott uploaded patch set 2
V -104/08/24, 16:32Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 2 V +1 04/08/24, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55572
-
Benjamin Franzke abandoned the change 04/08/24, 16:42
we will use getText and focus on new/better integrations