83710[BUGFIX] Improve UX and accessibility of action buttons in page module
Commit message
Review
-
Code review CR -1
- Benjamin Kott -1
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/Sass/component/_buttons.scss2+7 −0
- Build/Sources/Sass/module/_page.scss6+17 −10
- typo3/sysext/backend/Classes/Utility/BackendUtility.php1+6 −3
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php3+3 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/RecordDefault/Header.html4+41 −45
- typo3/sysext/backend/Resources/Public/Css/backend.css+6 −5
Review log 2535
Show 610 earlier messages
-
Ayke Halder uploaded patch set 1 04/08/24, 19:24
-
core-ci voted on patch set 1 V -1 04/08/24, 19:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55574
-
Ayke Halder uploaded patch set 2
V -104/08/24, 19:33 -
core-ci voted on patch set 2 V +1 04/08/24, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55575
-
Ayke Halder uploaded patch set 3
V +105/13/24, 10:37 -
core-ci voted on patch set 3 V +1 05/13/24, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57608
-
Simon Schaufelberger commented on patch set 3 07/12/24, 00:19
Is this still relevant and if so, can you please rebase? -
Andreas Kienast commented on patch set 3 CR -1 07/12/24, 13:33
GridColumnItem.php:187 -
Ayke Halder uploaded patch set 4
CR -1V +107/13/24, 10:19 -
core-ci voted on patch set 4 V +1 07/13/24, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61538
-
Ayke Halder uploaded patch set 5
V +107/13/24, 11:27 -
Ayke Halder commented on patch set 5 07/13/24, 11:31
I need to fix the rebase…GridColumnItem.php:187ReplyI changed it. Isn't there some exception for functions with too many paramters? As this function call uses 6 parameters now, of which 2 parameters are set to the functions default value. -
core-ci voted on patch set 5 V +1 07/13/24, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61540
-
Ayke Halder commented on patch set 5 CR +1 V +1 07/13/24, 11:36
Rebased and refactored to make use of already introduced CSS variables `--typo3-btn-…`Reply
Actually looks good right now! -
Ayke Halder commented on patch set 5 07/13/24, 11:37
Reply
Still relevant as UI/UX issue still exists. Rebased. -
Ayke Halder updated the commit message in patch set 6
CR +1V +107/13/24, 11:39 -
core-ci voted on patch set 6 V +1 07/13/24, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61541
-
Ayke Halder uploaded patch set 7
V +107/15/24, 12:14 -
Ayke Halder voted on patch set 7 CR +1 V +1 07/15/24, 12:19
-
core-ci voted on patch set 7 V -1 07/15/24, 12:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61580
-
Ayke Halder uploaded patch set 8
CR +1V +107/15/24, 12:31 -
core-ci voted on patch set 8 V +1 07/15/24, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61585
-
Ayke Halder voted on patch set 8 CR +1 V +1 07/15/24, 14:37
-
Christian Rath-Ulrich voted on patch set 8 CR +1 V +1 07/17/24, 14:59
-
Benjamin Kott commented on patch set 8 CR -1 07/18/24, 05:18
we will not merge these changes into 12.4, as we are too close to the release of 13. we already have massive changes in that areas and need dedicated patches would be needed. there is no more easy backport._buttons.scss:4we just started to scope more properties to avoid cluttering root, this should not be removed as we need it when moving to components with closed shadow dom._page.scss:207please do not introduce overrides of existing components outside of the _buttons.scss. we have a hard time getting rid of all the overrides to embrace useful components through the core. -
Ayke Halder uploaded patch set 9
CR +1V +107/18/24, 07:27 -
Andreas Kienast commented on patch set 9 CR -1 07/18/24, 07:29
Still a merge conflict -
core-ci voted on patch set 9 V -1 07/18/24, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61721
-
Ayke Halder uploaded patch set 10
CR -1V -107/18/24, 08:24 -
core-ci voted on patch set 10 V +1 07/18/24, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61733
-
Ayke Halder commented on patch set 10 07/18/24, 08:55
The elements "button" and "toolbar" have no interconnections anymore and are thereby self-contained.Reply
Acknowledged_buttons.scss:4ReplyI got your point - and I also think it is important to have components with their own shadow dom in the future. This will make it slightly harder to use the same style for buttons based on the context given by a parent element - but it is solvable._page.scss:207ReplyAcknowledged -
Benjamin Kott commented on patch set 10 CR -1 07/18/24, 10:09
Unresolved
we are in the process of dropping bootstrap from the backend, even if it`s aligned it´s nothing we should highlight. btn-group will see a split from the bootstrap upstream in the near future.BackendUtility.php:2031Unresolvedwe should not change this function, for now it only is a wrapper that we misuse across the backend and it´s more or less fitting nowhere. making this more flexible will greatly increase the problems.GridColumnItem.php:192Unresolvedimplement the button manually here. use BackendUtility::getContextMenuAttributes to get the arguments for the context menu.Header.html:1drop btn-toolbarHeader.html:10Unresolveddo not use navbar-textHeader.html:14Unresolveddo not mix responsibilities here keep t3-page-ce-header-right and btn-group separated -
Benjamin Kott commented on patch set 10 07/18/24, 10:17
_page.scss:175this is an assumption based on "manual", this is not based on character width or considers changing toolbars. i think setting the t3-page-ce-header-title to a minimum width like and build everything around that like `4ch`._page.scss:186i am still unsure about this part, if feels wrong having -y used here. i understand why you are doing this here - would need more time to play around with them. -
Ayke Halder commented on patch set 10 07/18/24, 11:07
_page.scss:175Reply UnresolvedIn case I set the width in the title-element instead of the header-element: ``` &-title { flex-grow: 1; flex-basis: 4ch; text-overflow: ellipsis; overflow: hidden; } ``` In Firefox on resizing the browser window I get some visual errors and `text-overflow: ellipsis` does not always get triggered. This might be a result of using a combination of flex-layout and `text-overflow: ellipsis`. --- Another point about resizing: Before this change `.t3-page-column` always kept a min-width of `300px` when at least one CE was inside. With this new code the CE can become even smaller. Maybe set a min-width of `(300px - 2 * grid-spacing)` for `.t3-page-ce`, so that the min-width is kept like before._page.scss:186Reply UnresolvedActually its all about this "square"-button. How about: ``` &-right { // borderless, square buttons inside: // visually align icon of last button with edge of this element --typo3-input-padding-x: var(--typo3-input-padding-y); margin-inline-end: calc((var(--typo3-input-padding-x) + var(--typo3-input-border-width)) * -1); ```Header.html:1Reply UnresolvedJust to not have it at this specific place? Or shoulf `btn-toolbar` in general get completely removed in the future by dropping Bootstrap? It is actually used in multiple places in the backend. -
Garvin Hicking abandoned the change 10/02/26, 12:12
I'm sorry, but there has been no movement here and we should abandon this approach.