Review main Abandoned

83710[BUGFIX] Improve UX and accessibility of action buttons in page module

Ayke Halder CR -1 V 0 Normal +80 −64 updated 10/02/26, 12:12

Commit message

This enlarges the click target area and adds hover and keyboard focus
feedback to the action buttons in the header of content elements to
improve the UX of the page module.

The buttons already have a transparent background and the visual
alignment of the icons only changes very slightly.

Further this change adds a geneneral option to set HTML-attributes and
especially the class attribute for icon-buttons. This enables future
changes of icon-buttons in other places of the TYPO3 backend.

The header toolbar of content element in page module uses proper
`Bootstrap` structure now.

This introduces a new class `.btn-square` which sets the horizontal
padding to the same value as the vertical padding.

Review

  • Code review CR -1
    • Benjamin Kott -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 6

Review log 2535

Show 610 earlier messages
  1. Ayke Halder uploaded patch set 1 04/08/24, 19:24

  2. core-ci voted on patch set 1 V -1 04/08/24, 19:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55574

  3. Ayke Halder uploaded patch set 2 V -1 04/08/24, 19:33

  4. core-ci voted on patch set 2 V +1 04/08/24, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55575

  5. Ayke Halder uploaded patch set 3 V +1 05/13/24, 10:37

  6. core-ci voted on patch set 3 V +1 05/13/24, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57608

  7. Simon Schaufelberger commented on patch set 3 07/12/24, 00:19

    Is this still relevant and if so, can you please rebase?
  8. Andreas Kienast commented on patch set 3 CR -1 07/12/24, 13:33

  9. Ayke Halder uploaded patch set 4 CR -1 V +1 07/13/24, 10:19

  10. core-ci voted on patch set 4 V +1 07/13/24, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61538

  1. Ayke Halder uploaded patch set 5 V +1 07/13/24, 11:27

  2. Ayke Halder commented on patch set 5 07/13/24, 11:31

    I need to fix the rebase…

    GridColumnItem.php:187 Reply

    I changed it. Isn't there some exception for functions with too many paramters? As this function call uses 6 parameters now, of which 2 parameters are set to the functions default value.
  3. core-ci voted on patch set 5 V +1 07/13/24, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61540

  4. Ayke Halder commented on patch set 5 CR +1 V +1 07/13/24, 11:36

    Rebased and refactored to make use of already introduced CSS variables `--typo3-btn-…`

    Reply

    Actually looks good right now!
  5. Ayke Halder commented on patch set 5 07/13/24, 11:37

    Reply

    Still relevant as UI/UX issue still exists. Rebased.
  6. Ayke Halder updated the commit message in patch set 6 CR +1 V +1 07/13/24, 11:39

  7. core-ci voted on patch set 6 V +1 07/13/24, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61541

  8. Ayke Halder uploaded patch set 7 V +1 07/15/24, 12:14

  9. Ayke Halder voted on patch set 7 CR +1 V +1 07/15/24, 12:19

  10. core-ci voted on patch set 7 V -1 07/15/24, 12:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61580

  11. Ayke Halder uploaded patch set 8 CR +1 V +1 07/15/24, 12:31

  12. core-ci voted on patch set 8 V +1 07/15/24, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61585

  13. Ayke Halder voted on patch set 8 CR +1 V +1 07/15/24, 14:37

  14. Christian Rath-Ulrich voted on patch set 8 CR +1 V +1 07/17/24, 14:59

  15. Benjamin Kott commented on patch set 8 CR -1 07/18/24, 05:18

    we will not merge these changes into 12.4, as we are too close to the release of 13. we already have massive changes in that areas and need dedicated patches would be needed. there is no more easy backport.

    _buttons.scss:4

    we just started to scope more properties to avoid cluttering root, this should not be removed as we need it when moving to components with closed shadow dom.

    _page.scss:207

    please do not introduce overrides of existing components outside of the _buttons.scss. we have a hard time getting rid of all the overrides to embrace useful components through the core.
  16. Ayke Halder uploaded patch set 9 CR +1 V +1 07/18/24, 07:27

  17. Andreas Kienast commented on patch set 9 CR -1 07/18/24, 07:29

    Still a merge conflict
  18. core-ci voted on patch set 9 V -1 07/18/24, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61721

  19. Ayke Halder uploaded patch set 10 CR -1 V -1 07/18/24, 08:24

  20. core-ci voted on patch set 10 V +1 07/18/24, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61733

  21. Ayke Halder commented on patch set 10 07/18/24, 08:55

    The elements "button" and "toolbar" have no interconnections anymore and are thereby self-contained.

    Reply

    Acknowledged

    _buttons.scss:4 Reply

    I got your point - and I also think it is important to have components with their own shadow dom in the future. This will make it slightly harder to use the same style for buttons based on the context given by a parent element - but it is solvable.

    _page.scss:207 Reply

    Acknowledged
  22. Benjamin Kott commented on patch set 10 CR -1 07/18/24, 10:09

    Unresolved

    we are in the process of dropping bootstrap from the backend, even if it`s aligned it´s nothing we should highlight. btn-group will see a split from the bootstrap upstream in the near future.

    BackendUtility.php:2031 Unresolved

    we should not change this function, for now it only is a wrapper that we misuse across the backend and it´s more or less fitting nowhere. making this more flexible will greatly increase the problems.

    GridColumnItem.php:192 Unresolved

    implement the button manually here. use BackendUtility::getContextMenuAttributes to get the arguments for the context menu.

    Header.html:1

    drop btn-toolbar

    Header.html:10 Unresolved

    do not use navbar-text

    Header.html:14 Unresolved

    do not mix responsibilities here keep t3-page-ce-header-right and btn-group separated
  23. Benjamin Kott commented on patch set 10 07/18/24, 10:17

    _page.scss:175

    this is an assumption based on "manual", this is not based on character width or considers changing toolbars. i think setting the t3-page-ce-header-title to a minimum width like and build everything around that like `4ch`.

    _page.scss:186

    i am still unsure about this part, if feels wrong having -y used here. i understand why you are doing this here - would need more time to play around with them.
  24. Ayke Halder commented on patch set 10 07/18/24, 11:07

    _page.scss:175 Reply Unresolved

    In case I set the width in the title-element instead of the header-element: ``` &-title { flex-grow: 1; flex-basis: 4ch; text-overflow: ellipsis; overflow: hidden; } ``` In Firefox on resizing the browser window I get some visual errors and `text-overflow: ellipsis` does not always get triggered. This might be a result of using a combination of flex-layout and `text-overflow: ellipsis`. --- Another point about resizing: Before this change `.t3-page-column` always kept a min-width of `300px` when at least one CE was inside. With this new code the CE can become even smaller. Maybe set a min-width of `(300px - 2 * grid-spacing)` for `.t3-page-ce`, so that the min-width is kept like before.

    _page.scss:186 Reply Unresolved

    Actually its all about this "square"-button. How about: ``` &-right { // borderless, square buttons inside: // visually align icon of last button with edge of this element --typo3-input-padding-x: var(--typo3-input-padding-y); margin-inline-end: calc((var(--typo3-input-padding-x) + var(--typo3-input-border-width)) * -1); ```

    Header.html:1 Reply Unresolved

    Just to not have it at this specific place? Or shoulf `btn-toolbar` in general get completely removed in the future by dropping Bootstrap? It is actually used in multiple places in the backend.
  25. Garvin Hicking abandoned the change 10/02/26, 12:12

    I'm sorry, but there has been no movement here and we should abandon this approach.