Review main Abandoned

83718[WIP][FEATURE] Add Fluid RenderRecord ViewHelper

Benni Mack CR 0 V 0 Normal +241 −0 updated 04/21/26, 15:09

Commit message

A new ViewHelper for Fluid is introduced, which is called
"<f:render.record>" and utilizes a Record object, and instantiates
a new View with an automatic template detected by the
Record Type (e.g. "Tt_content/Textpic.html" for "tt_content.textpic"
record type).

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 10

Review log 2331

Show 46 earlier messages
  1. Benni Mack uploaded patch set 1 04/09/24, 13:32

  2. core-ci voted on patch set 1 V -1 04/09/24, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55608

  3. Benni Mack uploaded patch set 2 V -1 04/09/24, 17:24

  4. core-ci voted on patch set 2 V -1 04/09/24, 17:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55623

  5. Christian Kuhn commented on patch set 2 04/09/24, 19:11

    RenderBlockViewHelper.php:67

    view in view. feels terrible at first thought. kinda like the old pagination approach we phased out because it did not proof to be a good idea. is this critical? what are the reasons to deviate from a casual partial approach? could we please talk on this a bit more?
  6. André Buchmann commented on patch set 2 04/10/24, 17:56

    Viewhelper should provide some context Where am I from? Colpos? Which cycle? CEs before/after
  1. Benni Mack rebased onto patch set 3 V -1 08/27/24, 20:00

  2. core-ci voted on patch set 3 V -1 08/27/24, 20:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64364

  3. Simon Praetorius uploaded patch set 4 V -1 08/30/24, 17:05

  4. Simon Praetorius commented on patch set 4 08/30/24, 17:06

    RenderBlockViewHelper.php:67 Reply

    Done
  5. core-ci voted on patch set 4 V -1 08/30/24, 17:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64541

  6. Simon Praetorius uploaded patch set 5 V -1 08/31/24, 10:06

  7. Simon Praetorius uploaded patch set 6 08/31/24, 10:06

  8. core-ci voted on patch set 5 V -1 08/31/24, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64580

  9. core-ci voted on patch set 6 V -1 08/31/24, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64581

  10. Benni Mack uploaded patch set 7 V -1 09/11/24, 10:24

  11. core-ci voted on patch set 7 V -1 09/11/24, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65418

  12. Christian Kuhn voted on patch set 7 CR -2 09/16/24, 13:46

  13. Christian Kuhn commented on patch set 7 CR 0 09/16/24, 15:42

    it looks to me as if this is too late for v13 now, and i think some details have not been fully ruled out, yet. we may want to put this VH into some extension for people to use it in v13 already if needed. i'll not vote this up for v13 anymore.
  14. Lina Wolf commented on patch set 7 10/03/24, 12:21

    Reply

    I really like the idea of putting this ViewHelper in an extension for v13 and then possibly have it ready for v14.
  15. André Buchmann commented on patch set 7 11/14/24, 15:29

    This viewhelper is in its current state incompatible with content-blocks. As the cb:assetPath() viewhelper has no context. Adding `'table' => 'tt_content'` to the arguments solves the context issue. Error Message: (1/1) #1701198923 TYPO3Fluid\Fluid\Exception TYPO3\CMS\ContentBlocks\ViewHelpers\AssetPathViewHelper seemingly called outside Content Blocks context. TYPO3 13.4.1 content-blocks 1.0.4 I just want to raise awareness. Not sure if this is more a problem of content-blocks itself.
  16. André Buchmann uploaded patch set 8 V -1 11/18/24, 11:35

  17. André Buchmann commented on patch set 8 11/18/24, 11:38

    Reply Unresolved

    This is resolved for the records which are rendered via the "innerView". Not resolved for elements called with f:cObject.

    Reply

    Resolved with: `'table' => $record->getMainType(),`
  18. core-ci voted on patch set 8 V +1 11/18/24, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69590

  19. Georg Ringer commented on patch set 8 11/19/24, 20:34

    if this is a kind of missing feature I am for having that in 13 as well. no need to make the life of people harder
  20. Nikita Hovratov commented on patch set 8 11/19/24, 21:22

    Reply

    Or we do what lolli said and put it into a extension for v13. What about integrating it into Content Blocks? This is anyway the place, we would want to have such kind out auto-template resolving. Not sure how great the benefit would be to have 2 separate solutions for template resolving in place, when CB will make it into the Core. One thing I miss are partials / layouts. Normally those are defined via TypoScript, so how would this work? Also additional dataProcessors are probably also not possible without the TypoScript route, or?
  21. André Buchmann commented on patch set 8 11/19/24, 21:49

    Reply

    Partials and Layouts are resolved from the same paths that the parent (page) has defined. This can cause trouble if the page and the content element make use of <f:layout name="Default" /> as both resolve to the same layout. The subfolder "Tt_content" is only added for the template path itself. Currently no additional dataProcessors are available.
  22. Nikita Hovratov commented on patch set 8 11/19/24, 22:09

    Reply

    Ohh, yeah this might cause big trouble. Having no way to register additional data processors might cause frustration as well. Imagine you are working on your template, until you discover you need a data processor and because of that you need to switch back to TypoScript rendering definition. And then having mixed Content Elements, some with and some without data processing.
  23. Oli Bartsch commented on patch set 8 11/20/24, 08:51

    Reply Unresolved

    Besides the limitation regarding data processors, we also need to provide context to the templates. Therefore I created https://review.typo3.org/c/Packages/TYPO3.CMS/+/86104 a while ago.
  24. Benni Mack marked it work in progress 01/08/25, 16:25

  25. Benni Mack abandoned the change 04/21/26, 15:09

    won't do