Review main Merged

83720[BUGFIX] Correctly infer site for new page

Mathias Bolt Lesniak CR +2 V +2 Easy +23 −1 updated 08/03/24, 11:24

Commit message

SiteResolving will now correctly interpret a temporary ID of a new page (e.g., "NEW12345678ABCDEF") as an invalid ID and try to infer the site using `$result['effectivePid']`.

This makes it possible to access site configuration properties within the TCA also on pages that have yet to be created.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1823

  1. Mathias Bolt Lesniak uploaded patch set 1 04/09/24, 15:13

  2. Mathias Bolt Lesniak updated the commit message in patch set 2 04/09/24, 15:15

  3. core-ci voted on patch set 1 V +1 04/09/24, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55612

  4. core-ci voted on patch set 2 V +1 04/09/24, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55613

  5. Andreas Kienast commented on patch set 2 04/09/24, 16:53

    SiteResolving.php:59

    Is it safe that `$result['databaseRow']['uid']` can never be null?
  6. Mathias Bolt Lesniak uploaded patch set 3 V +1 04/09/24, 18:42

  7. Mathias Bolt Lesniak commented on patch set 3 04/09/24, 18:43

    SiteResolving.php:59 Reply

    Good point. Corrected in patchset 3.
  8. core-ci voted on patch set 3 V +1 04/09/24, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55632

  9. Oliver Klee commented on patch set 3 04/24/24, 11:08

    SiteResolvingTest.php:70

    The core is not using Prophecy anymore. So there are no revelations either, just mocks.

    SiteResolvingTest.php:76

    I propose using a local variable for 42 to make it clear to the ready that these two numbers are the same on purpose on not by chance.
  10. Mathias Bolt Lesniak commented on patch set 3 04/24/24, 14:21

    SiteResolvingTest.php:70 Reply

    This naming scheme is used throughout the test file. I would suggest making this change in a separate patch.

    SiteResolvingTest.php:76 Reply

    This pattern is used throughout the test file. I would suggest making this change in a separate patch.
  11. Oliver Klee wrote 04/24/24, 15:00

    Removed cc Oliver Klee.
  12. Mathias Bolt Lesniak commented on patch set 3 04/25/24, 08:45

    SiteResolvingTest.php:70 Reply

    Oliver and I agree that this can be marked as resolved.

    SiteResolvingTest.php:76 Reply

    Oliver and I agree that this can be marked as resolved.
  13. Oliver Klee voted on patch set 3 V +1 04/25/24, 08:46

  14. Mathias Bolt Lesniak rebased onto patch set 4 V +1 05/31/24, 06:08

  15. Andreas Kienast voted on patch set 4 CR +1 05/31/24, 06:13

  16. core-ci voted on patch set 4 V +1 05/31/24, 06:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58518

  17. Andreas Kienast uploaded patch set 5 CR +1 V +1 05/31/24, 06:26

  18. core-ci voted on patch set 5 V +1 05/31/24, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58520

  19. Andreas Kienast voted on patch set 5 CR +1 05/31/24, 06:41

  20. Georg Ringer voted on patch set 5 CR +1 V +1 05/31/24, 19:26

  21. Simon Schaufelberger voted on patch set 5 CR +1 V +1 07/03/24, 13:24

  22. Andreas Kienast voted on patch set 5 CR +2 V +2 08/03/24, 10:56

  23. Andreas Kienast merged patch set 6 08/03/24, 11:24