83720[BUGFIX] Correctly infer site for new page
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1823
-
Mathias Bolt Lesniak uploaded patch set 1 04/09/24, 15:13
-
Mathias Bolt Lesniak updated the commit message in patch set 2 04/09/24, 15:15
-
core-ci voted on patch set 1 V +1 04/09/24, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55612
-
core-ci voted on patch set 2 V +1 04/09/24, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55613
-
Andreas Kienast commented on patch set 2 04/09/24, 16:53
-
Mathias Bolt Lesniak uploaded patch set 3
V +104/09/24, 18:42 -
Mathias Bolt Lesniak commented on patch set 3 04/09/24, 18:43
SiteResolving.php:59ReplyGood point. Corrected in patchset 3. -
core-ci voted on patch set 3 V +1 04/09/24, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55632
-
Oliver Klee commented on patch set 3 04/24/24, 11:08
SiteResolvingTest.php:70The core is not using Prophecy anymore. So there are no revelations either, just mocks.SiteResolvingTest.php:76I propose using a local variable for 42 to make it clear to the ready that these two numbers are the same on purpose on not by chance. -
Mathias Bolt Lesniak commented on patch set 3 04/24/24, 14:21
SiteResolvingTest.php:70ReplyThis naming scheme is used throughout the test file. I would suggest making this change in a separate patch.SiteResolvingTest.php:76ReplyThis pattern is used throughout the test file. I would suggest making this change in a separate patch. -
Oliver Klee wrote 04/24/24, 15:00
Removed cc Oliver Klee. -
Mathias Bolt Lesniak commented on patch set 3 04/25/24, 08:45
SiteResolvingTest.php:70ReplyOliver and I agree that this can be marked as resolved.SiteResolvingTest.php:76ReplyOliver and I agree that this can be marked as resolved. -
Oliver Klee voted on patch set 3 V +1 04/25/24, 08:46
-
Mathias Bolt Lesniak rebased onto patch set 4
V +105/31/24, 06:08 -
Andreas Kienast voted on patch set 4 CR +1 05/31/24, 06:13
-
core-ci voted on patch set 4 V +1 05/31/24, 06:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58518
-
Andreas Kienast uploaded patch set 5
CR +1V +105/31/24, 06:26 -
core-ci voted on patch set 5 V +1 05/31/24, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58520
-
Andreas Kienast voted on patch set 5 CR +1 05/31/24, 06:41
-
Georg Ringer voted on patch set 5 CR +1 V +1 05/31/24, 19:26
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 07/03/24, 13:24
-
Andreas Kienast voted on patch set 5 CR +2 V +2 08/03/24, 10:56
-
Andreas Kienast merged patch set 6 08/03/24, 11:24
SiteResolving.php:59