Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
83724[WIP][BUGFIX] Improve accessibility of the view modules menubar
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 14
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/24/83724/14 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/24/83724/14 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 2
-
83724 [WIP][BUGFIX] Improve accessibility of the view modules menubar This change
-
main
91134[BUGFIX] Improve accessibility of the view module
The chain has patch set 3 of 5, the changes above it need a rebase.
Issues 1
Files 2
Review log 2943
Show 1318 earlier messages
-
Ayke Halder uploaded patch set 1 04/09/24, 19:27
-
core-ci voted on patch set 1 V +1 04/09/24, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55634
-
Christian Rath-Ulrich voted on patch set 1 CR +1 V +1 07/17/24, 15:29
-
Benjamin Kott commented on patch set 1 CR -1 07/18/24, 06:48
merge conflict -
Ayke Halder uploaded patch set 2
CR +1V +107/18/24, 08:40 -
core-ci voted on patch set 2 V +1 07/18/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61735
-
Benjamin Kott commented on patch set 2 CR -1 V -1 07/18/24, 10:36
_card.scss:244do you have an example where that is actually used? i am more in favor dropping this completely._resources.scss:120this was left out on purpose to avoid having keyboard users tab through each and every checkbox. we currently do not have a concept on how this module and the multi record selection should work in the tile mode. for now i think this will decrease the usability._page.scss:106good!_page.scss:159good!_viewpage.scss:87good! -
Ayke Halder commented on patch set 2 07/18/24, 14:12
Drop `a.card` or keep it?_card.scss:244ReplyI really had to do a search to find the only one use-case in the core. RegexSearch for files `*.php,*.html,*.ts` containing: `<a[^<>]+['"]([^'"<>]+ )?card( [^'"<>]+)?['"]` `typo3/sysext/reports/Resources/Private/Templates/Report/Index.html`: ``` <section class="card-container"> <f:for each="{reports}" as="report"> <a href="{be:moduleLink(route: 'system_reports', arguments: '{action: \'detail\', report: report.identifier}')}" title="{f:translate(key: report.title, default: report.title)}" class="card card-size-medium" > ``` Can we somehow remove this use-case, or shall we keep `a.card`?_resources.scss:120ReplyAlso touch-screen-users can not reach this checkbox. I remove it from this patch, as this needs a new usability concept - e.g. always show the checkbox. Also see touch with on-hover for tooltips: https://inclusive-components.design/tooltips-toggletips/#touchinteraction_page.scss:106ReplyDone_page.scss:159ReplyDone_viewpage.scss:87ReplyDone -
Jasmina Ließmann commented on patch set 2 07/18/24, 19:03
_card.scss:244ReplyI already have this view on my list and will provide a separate patch for it. From my side, `a.card` can be removed in this patch. -
Ayke Halder uploaded patch set 3
CR -1V +107/23/24, 21:41 -
core-ci voted on patch set 3 V -1 07/23/24, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62049
-
Ayke Halder commented on patch set 3 07/23/24, 21:48
_card.scss:244Reply`a.card` is not changed by this anymore._resources.scss:120ReplyCheckbox behaviour is not touched anymore. -
Ayke Halder uploaded patch set 4
V -107/23/24, 21:56 -
core-ci voted on patch set 4 V -1 07/23/24, 22:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62050
-
Ayke Halder uploaded patch set 5
V -107/23/24, 22:02 -
core-ci voted on patch set 5 V +1 07/23/24, 22:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62051
-
Jasmina Ließmann commented on patch set 5 07/24/24, 06:56
_card.scss:244ReplyFor the sake of completeness - the patch for the reports module: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85340 -
Benjamin Kott uploaded patch set 6
V +109/10/24, 13:38
-
Benjamin Kott commented on patch set 6 CR -1 09/10/24, 13:40
@mail@ayke-halder.de please split the commit in page module and view module. I´ve adjusted the page module part and this would be ready to go in. I need to recheck the view module, as i am also unsure about some aria-label beeing on elements and muting the controls below. -
core-ci voted on patch set 6 V +1 09/10/24, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65253
-
Jasmina Ließmann wrote 09/10/24, 13:47
Removed cc Jasmina Ließmann. -
Ayke Halder commented on patch set 6 CR -1 09/16/24, 16:49
Unresolved
I have one issue on the page-module introduced with `Patchset 6`. I'll do the split of page-module and view-module when resolved.Reply Unresolved
This doesn't look ready for me. Especially why was this one here removed with `Patchset 6`? ``` diff --git a/Build/Sources/Sass/module/_page.scss b/Build/Sources/Sass/module/_page.scss index e58932a..97020a9 100644 --- a/Build/Sources/Sass/module/_page.scss +++ b/Build/Sources/Sass/module/_page.scss @@ -82,8 +82,6 @@ .t3-page-column-header { font-weight: $font-weight-bold; margin: var(--pagemodule-element-spacing) var(--pagemodule-grid-inner-spacing); - // duplicate offset for edit icon, inverted in .t3-page-column-header-icons - margin-inline-end: calc(var(--pagemodule-grid-inner-spacing) * 2); position: relative; text-align: start; font-size: var(--pagemodule-grid-cell-header-size); @@ -95,14 +93,16 @@ } .t3-page-column-header-icons { - @include transition(opacity .15s ease-in); - opacity: .3; - position: absolute; - inset-inline-end: calc(var(--pagemodule-grid-inner-spacing) * -1); - bottom: 0; + float: inline-end; - &:hover { - opacity: 1; + a { + @include transition(opacity .15s ease-in); + opacity: .3; + + &:hover, + &:focus { + opacity: 1; + } } } ``` The coresponding HTML code looks like this: ``` <div class="t3-page-column-header-icons"> <a href="/typo3/record/edit?…" title="Edit this column"> <span class="t3js-icon icon icon-size-small icon-state-default icon-actions-document-open" data-identifier="actions-document-open" aria-hidden="true"> <span class="icon-markup"> <svg class="icon-color"><use xlink:href="/typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-document-edit"></use></svg> </span> </span> </a> </div> ``` So on focus/hover we should change the opacity of the anchor itself here and not the opacity of the surrounding element which contains *all the anchors* - actually it's *one anchor* only for now. -
Benjamin Kott uploaded patch set 7
CR -1V +111/15/24, 12:02 -
core-ci voted on patch set 7 V +1 11/15/24, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69476
-
Benjamin Kott commented on patch set 7 CR -1 V -1 11/15/24, 12:54
needs more testing -
Benjamin Kott uploaded patch set 8
CR -1V +111/15/24, 13:14 -
Benjamin Kott uploaded patch set 9 11/15/24, 13:15
-
core-ci voted on patch set 8 V +1 11/15/24, 13:23 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 9 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69480
-
core-ci voted on patch set 9 V +1 11/15/24, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69482
-
Benjamin Kott uploaded patch set 10
V +111/18/24, 16:47 -
core-ci voted on patch set 10 V +1 11/18/24, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69609
-
Benni Mack marked it work in progress 01/08/25, 15:56
-
Michael Telgkamp commented on patch set 10 V -1 10/16/25, 19:04
In main the color contrasts of the elements mentioned in https://forge.typo3.org/issues/103583 are sufficient WCAG. The other changes (add labels and menu roles) are not part of the issue description. In my opinion it would be good to add a new issue for the missing label and fix them. Also adding the groups looks fine to me and could be done in the labeling issue. Adding the menu for the persistent elements is not valid, additionally the keyboard behavior would need to be adjusted to reflect the expected behavior for role `menu` / `menubar`.Show.html:18Using role menu here is not valid. More information under https://www.w3.org/WAI/ARIA/apg/patterns/menubar/ The requirements are not met here. > "Unlike a menubar, a menu is not visually persistent, and authors are responsible for ensuring focus moves to an item inside of a menu when the menu opens." -
Ayke Halder uploaded patch set 11
V +110/17/25, 13:56 -
core-ci voted on patch set 11 V +1 10/17/25, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86910
-
Ayke Halder uploaded patch set 12
V +110/17/25, 14:28 -
core-ci voted on patch set 12 V -1 10/17/25, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86920
-
Ayke Halder rebased onto patch set 13
V -110/17/25, 15:32 -
Michael Telgkamp commented on patch set 13 V -1 10/17/25, 15:37
The forge issue referenced here, is on the opacity of icons, this patchset now adds roles and a label. There should be another issue in forge for this valid changes and this issue then needs to be referenced here.Show.html:18ReplyDone -
core-ci voted on patch set 13 V +1 10/17/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86933
-
Ayke Halder updated the commit message in patch set 14
V +110/17/25, 15:44 -
Ayke Halder commented on patch set 14 10/17/25, 15:47
Reply
Done -
core-ci voted on patch set 14 V +1 10/17/25, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86935