Review main Merged

83726[BUGFIX] Avoid overriding of custom `doktypesToShowInNewPageDragArea`

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 05/03/24, 07:00

Commit message

With the introduction of BeforeLoadedUserTsConfigEvent, it is now
possible to add user tsconfig before global file user.tsconfig is
evaluated. The registry-like `doktypesToShowInNewPageDragArea` list
always overrides possible items added in this event. The fix is to use
the `addToList` modifier, so that default doktypes are appended.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Nikita Hovratov uploaded patch set 1 04/10/24, 08:32

  2. core-ci voted on patch set 1 V +1 04/10/24, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55670

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 04/10/24, 09:27

  4. Nikita Hovratov voted on patch set 1 CR +1 05/01/24, 18:02

  5. Nikita Hovratov voted on patch set 1 CR 0 05/01/24, 18:02

  6. Benni Mack voted on patch set 1 CR +2 V +2 05/03/24, 07:00

  7. Benni Mack merged patch set 2 05/03/24, 07:00