Review main Abandoned

83727[BUGFIX] Improve horizontal scrolling in page module

Albrecht Köhnlein CR 0 V 0 Easy +1 −3 updated 12/16/24, 08:52

Commit message

The horizontal scrollbar in the backend page module currently is only
visible after scrolling to the bottom of the page. This change brings
the scrollbars back to the iframe, which allows the backend user to
immediately see and use the scrollbars.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 712

  1. Albrecht Köhnlein uploaded patch set 1 04/10/24, 09:48

  2. Albrecht Köhnlein updated the commit message in patch set 2 04/10/24, 09:50

  3. core-ci voted on patch set 1 V +1 04/10/24, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55671

  4. core-ci voted on patch set 2 V +1 04/10/24, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55672

  5. Oliver Klee updated the commit message in patch set 3 V +1 04/10/24, 10:17

  6. core-ci voted on patch set 3 V +1 04/10/24, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55673

  7. Albrecht Köhnlein updated the commit message in patch set 4 V +1 04/10/24, 10:35

  8. core-ci voted on patch set 4 V +1 04/10/24, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55674

  9. Stefan Bürk commented on patch set 4 CR -1 04/10/24, 14:53

    Unresolved

    This brings the scrollbar back on an other level, but due to the removed overflow the `container` border is no longer spanned across all language rows, leading to a weired looking thing. So this should considered as well how to deal with it. Putting -1 on it so ux/ui people can have a look in this. Will upload a image to the issue.
  10. Benni Mack updated the commit message in patch set 5 CR -1 V +1 10/18/24, 13:25

  11. core-ci voted on patch set 5 V -1 10/18/24, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67964

  12. Benni Mack abandoned the change 12/16/24, 08:52

    Hey albi, I will abandon this change as we'll come up with a different solution for this issue. I believe it's mainly about the "Language Comparision View" - the other parts are fine IMHO. If you need any further feedback, feel free to ping me on slack.