83728[WIP][BUGFIX] Merge PageTSConfig to flexform field 'config' in FormEngine
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 9
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/28/83728/9 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/28/83728/9 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 2
Issues 4
- Bug #103532Using TSconfig TCEFORM to change existing flexform field configuration does not work
- Bug #102595Not possible to override richtextConfiguration via TSconfig if in a flexform
- Feature #36609Overwriting flexform in page TSConfig is not respected in TCEMain
- Feature #91690Override Flexform via Page TsConfig
Files 2
Review log 1119
-
Stefan Bürk uploaded patch set 1 04/10/24, 11:02
-
Stefan Bürk updated the commit message in patch set 2 04/10/24, 11:07
-
core-ci voted on patch set 1 V +1 04/10/24, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55675
-
core-ci voted on patch set 2 V +1 04/10/24, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55676
-
Stefan Bürk updated the commit message in patch set 3
V +104/10/24, 11:15 -
Stefan Bürk updated the commit message in patch set 4 04/10/24, 11:18
-
core-ci voted on patch set 3 V +1 04/10/24, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55677
-
core-ci voted on patch set 4 V +1 04/10/24, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55679
-
Garvin Hicking uploaded patch set 5
V +104/11/24, 12:12Add test -
core-ci voted on patch set 5 V +1 04/11/24, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55770
-
Garvin Hicking commented on patch set 5 CR +1 V +1 04/11/24, 12:19
I tested this with a few overrides, and added the automatic tests for it. It seems to work well for me, but to be honest I can't comment much on possible side-effects it could have, that I haven't tested. The one thing that would make this patch a bit more "user friendly" is that if we could make this ".types." subkey part not mandatory, so that the code would then work as it was previously documented. Thanks so much for digging into this and working together with me, this gave me a lot of insight. -
Benni Mack updated the commit message in patch set 6
CR +1V +110/18/24, 13:26 -
core-ci voted on patch set 6 V -1 10/18/24, 17:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67965
-
Benni Mack rebased onto patch set 7
V -110/18/24, 17:57 -
Garvin Hicking updated the commit message in patch set 8 01/21/25, 13:03
-
core-ci voted on patch set 8 V -1 01/21/25, 13:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72783
-
Benni Mack marked it work in progress 01/21/25, 14:05
-
Garvin Hicking uploaded patch set 9
V -101/21/25, 14:15 -
core-ci voted on patch set 9 V +1 01/21/25, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72789