83729[TASK] Use refindex in RootlineUtility, drop addRootLineFields
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- André Buchmann +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- André Buchmann +1
- Benni Mack +1
- core-ci +1 CI
Issues 7
- Task #103752Use refindex in RootlineUtility, drop addRootLineFields
- Task #103748Enrich ReferenceIndex with more relation data
- Task #103735Return more record info in RelationHandler->readMM()
- Task #103710Remove left over refindex _FILE handling
- Task #103680Add RootlineUtility relation tests
- Bug #103599RootlineUtility keeps relations deleted in workspaces
- Task #103598Increase RootlineUtility functional test coverage
Files 9
- typo3/sysext/core/Classes/Utility/RootlineUtility.php3+203 −68
- typo3/sysext/core/Configuration/DefaultConfiguration.php+0 −1
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+0 −3
- typo3/sysext/core/Documentation/Changelog/13.2/Deprecation-103752-ObsoleteGLOBALSTYPO3_CONF_VARSFEaddRootLineFields.rstnew+49 −0
- typo3/sysext/core/Documentation/Changelog/13.2/Important-103748-ReferenceIndexRebuildRequired.rst+3 −3
- typo3/sysext/core/Tests/Functional/Utility/Fixtures/RootlineUtilityImport.csv+44 −0
- typo3/sysext/core/Tests/Functional/Utility/RootlineUtilityTest.php+238 −50
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+2 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+5 −0
Review log 70124
Show 5299 earlier messages
-
Christian Kuhn uploaded patch set 1 04/10/24, 11:17
-
core-ci voted on patch set 1 V -1 04/10/24, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55678
-
Christian Kuhn uploaded patch set 2
V -104/10/24, 11:25 -
core-ci voted on patch set 2 V +1 04/10/24, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55680
-
Christian Kuhn uploaded patch set 3
V +104/10/24, 11:47 -
core-ci voted on patch set 3 V +1 04/10/24, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55681
-
Christian Kuhn uploaded patch set 4
V +104/10/24, 13:09 -
core-ci voted on patch set 4 V +1 04/10/24, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55682
-
Christian Kuhn uploaded patch set 5
V +104/11/24, 07:14 -
core-ci voted on patch set 5 V +1 04/11/24, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55735
-
Christian Kuhn uploaded patch set 6
V +104/12/24, 09:13 -
core-ci voted on patch set 6 V +1 04/12/24, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55845
-
Christian Kuhn uploaded patch set 7
V +104/12/24, 13:27 -
core-ci voted on patch set 7 V +1 04/12/24, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55872
-
Christian Kuhn uploaded patch set 8
V +104/12/24, 15:40 -
core-ci voted on patch set 8 V +1 04/12/24, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55875
-
Nikita Hovratov commented on patch set 8 04/12/24, 23:15
-
Christian Kuhn uploaded patch set 9
V +104/14/24, 08:45 -
core-ci voted on patch set 9 V +1 04/14/24, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55940
-
Christian Kuhn commented on patch set 9 04/14/24, 10:27
RootlineUtility.php:349Replythx. i see. i'll have a closer look at this when time is right. -
Christian Kuhn uploaded patch set 10
V +104/14/24, 10:35 -
core-ci voted on patch set 10 V +1 04/14/24, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55941
-
Christian Kuhn uploaded patch set 11
V +104/14/24, 12:26 -
core-ci voted on patch set 11 V +1 04/14/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55948
-
Christian Kuhn uploaded patch set 12
V +104/14/24, 13:16 -
core-ci voted on patch set 12 V +1 04/14/24, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55952
-
Christian Kuhn uploaded patch set 13
V +104/15/24, 06:47 -
core-ci voted on patch set 13 V +1 04/15/24, 06:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55979
-
Christian Kuhn uploaded patch set 14
V +104/15/24, 08:54 -
core-ci voted on patch set 14 V +1 04/15/24, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55985
-
Christian Kuhn uploaded patch set 15
V +104/15/24, 11:24 -
core-ci voted on patch set 15 V -1 04/15/24, 11:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55989
-
Christian Kuhn uploaded patch set 16
V -104/15/24, 11:34 -
core-ci voted on patch set 16 V +1 04/15/24, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55990
-
Christian Kuhn uploaded patch set 17
V +104/16/24, 12:58 -
core-ci voted on patch set 17 V +1 04/16/24, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56081
-
Christian Kuhn uploaded patch set 18
V +104/16/24, 14:00 -
core-ci voted on patch set 18 V +1 04/16/24, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56088
-
Christian Kuhn uploaded patch set 19
V +104/16/24, 15:35 -
core-ci voted on patch set 19 V +1 04/16/24, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56092
-
Christian Kuhn uploaded patch set 20
V +104/17/24, 09:49 -
core-ci voted on patch set 20 V +1 04/17/24, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56144
-
Christian Kuhn commented on patch set 20 04/17/24, 11:48
RootlineUtility.php:349Reply -
Christian Kuhn uploaded patch set 21
V +104/17/24, 13:50 -
core-ci voted on patch set 21 V +1 04/17/24, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56167
-
Christian Kuhn uploaded patch set 22
V +104/18/24, 13:16 -
core-ci voted on patch set 22 V +1 04/18/24, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56264
-
Christian Kuhn commented on patch set 22 04/19/24, 07:52
set 22 should extract the given RU tests as pre-patch. -
Christian Kuhn uploaded patch set 23
V +104/19/24, 07:58 -
core-ci voted on patch set 23 V -1 04/19/24, 08:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56308
-
Christian Kuhn uploaded patch set 24
V -104/19/24, 20:20 -
core-ci voted on patch set 24 V -1 04/19/24, 20:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56360
-
Christian Kuhn uploaded patch set 25
V -104/22/24, 08:24 -
core-ci voted on patch set 25 V -1 04/22/24, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56476
-
Christian Kuhn uploaded patch set 26
V -104/22/24, 23:17 -
core-ci voted on patch set 26 V -1 04/22/24, 23:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56514
-
Christian Kuhn uploaded patch set 27
V -104/23/24, 07:12 -
core-ci voted on patch set 27 V -1 04/23/24, 07:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56548
-
Christian Kuhn uploaded patch set 28
V -104/23/24, 09:54 -
core-ci voted on patch set 28 V -1 04/23/24, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56559
-
Christian Kuhn uploaded patch set 29
V -104/23/24, 14:18 -
core-ci voted on patch set 29 V -1 04/23/24, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56585
-
Christian Kuhn uploaded patch set 30
V -104/24/24, 11:47 -
core-ci voted on patch set 30 V -1 04/24/24, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56658
-
Christian Kuhn uploaded patch set 31
V -104/25/24, 07:43 -
core-ci voted on patch set 31 V -1 04/25/24, 07:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56690
-
Christian Kuhn uploaded patch set 32
V -104/25/24, 10:53 -
core-ci voted on patch set 32 V -1 04/25/24, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56694
-
Christian Kuhn uploaded patch set 33
V -104/25/24, 11:32 -
core-ci voted on patch set 33 V -1 04/25/24, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56697
-
Christian Kuhn uploaded patch set 34
V -104/25/24, 12:12 -
core-ci voted on patch set 34 V +1 04/25/24, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56700
-
Christian Kuhn uploaded patch set 35
V +104/26/24, 08:43 -
core-ci voted on patch set 35 V +1 04/26/24, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56759
-
Christian Kuhn uploaded patch set 36
V +104/26/24, 08:54 -
core-ci voted on patch set 36 V +1 04/26/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56761
-
Christian Kuhn uploaded patch set 37
V +104/26/24, 10:52 -
core-ci voted on patch set 37 V -1 04/26/24, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56773
-
Christian Kuhn uploaded patch set 38
V -104/26/24, 10:58 -
core-ci voted on patch set 38 V +1 04/26/24, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56774
-
Christian Kuhn uploaded patch set 39
V +104/26/24, 11:20 -
core-ci voted on patch set 39 V +1 04/26/24, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56776
-
Christian Kuhn uploaded patch set 40
V +104/26/24, 12:29 -
core-ci voted on patch set 40 V +1 04/26/24, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56778
-
Christian Kuhn uploaded patch set 41
V +104/26/24, 22:43 -
core-ci voted on patch set 41 V +1 04/26/24, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56815
-
Christian Kuhn uploaded patch set 42
V +104/27/24, 14:35 -
core-ci voted on patch set 42 V +1 04/27/24, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56856
-
Christian Kuhn uploaded patch set 43
V +104/28/24, 09:40 -
core-ci voted on patch set 43 V +1 04/28/24, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56907
-
Christian Kuhn uploaded patch set 44
V +104/28/24, 10:28 -
core-ci voted on patch set 44 V +1 04/28/24, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56908
-
Christian Kuhn uploaded patch set 45
V +104/28/24, 12:03 -
core-ci voted on patch set 45 V +1 04/28/24, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56913
-
Christian Kuhn uploaded patch set 46
V +104/28/24, 12:10 -
core-ci voted on patch set 46 V +1 04/28/24, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56915
-
Christian Kuhn updated the commit message in patch set 47
V +104/28/24, 14:11 -
core-ci voted on patch set 47 V +1 04/28/24, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56917
-
Oliver Klee updated the commit message in patch set 48
V +104/28/24, 14:27
-
Christian Kuhn updated the commit message in patch set 49 04/28/24, 14:33
-
core-ci voted on patch set 48 V +1 04/28/24, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56920
-
Christian Kuhn updated the commit message in patch set 50 04/28/24, 14:35
-
core-ci voted on patch set 50 V +1 04/28/24, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56922
-
core-ci voted on patch set 49 V +1 04/28/24, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56921
-
Christian Kuhn updated the commit message in patch set 51
V +104/28/24, 14:43 -
core-ci voted on patch set 51 V +1 04/28/24, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56923
-
Christian Kuhn updated the commit message in patch set 52
V +104/28/24, 15:14 -
Stefan Bürk voted on patch set 51 CR +1 V +1 04/28/24, 15:14
-
core-ci voted on patch set 52 V +1 04/28/24, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56924
-
Stefan Bürk voted on patch set 52 CR +1 V +1 04/28/24, 15:20
-
Nikita Hovratov voted on patch set 52 CR +1 04/28/24, 17:00
-
Simon Schaufelberger updated the commit message in patch set 53
CR +1V +104/28/24, 17:01 -
core-ci voted on patch set 53 V +1 04/28/24, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56925
-
Anja Leichsenring voted on patch set 53 CR +1 V +1 04/28/24, 17:31
-
Stefan Bürk voted on patch set 53 CR +1 V +1 04/28/24, 17:48
-
Albrecht Köhnlein commented on patch set 53 04/28/24, 18:39
post -
Stefan Bürk updated the commit message in patch set 54
CR +1V +104/28/24, 18:42 -
Stefan Bürk commented on patch set 54 CR +1 V +1 04/28/24, 18:42
Reply
Done -
core-ci voted on patch set 54 V +1 04/28/24, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56929
-
André Buchmann voted on patch set 54 CR +1 V +1 04/28/24, 19:18
-
Anja Leichsenring voted on patch set 54 CR +1 V +1 04/28/24, 19:40
-
Benni Mack voted on patch set 54 CR +1 V +1 04/29/24, 07:32
-
Christian Kuhn voted on patch set 54 CR +2 V +2 04/29/24, 07:38
-
Christian Kuhn merged patch set 55 04/29/24, 07:42
RootlineUtility.php:349