Review main Merged

83733[TASK] Improve UX and accessibility of "Indexing" submodules

Jasmina Ließmann CR +2 V +2 Hard +353 −265 updated 04/17/24, 11:32

Commit message

Several minor adjustments have been made to the submodules of the
“Indexing” backend module to improve the UX and accessibility.

This includes, among other things, the following:
* move action links to a dedicated control/button-group column
* use badges for label 'Not indexed'
* set unique h1 in all submodules
* use correct heading levels (h2/h3)
* show infobox when either no page has been selected or no results
  exists and unify locallang labels
* add label to back-button in statisticDetailsAction
* move back-button to docheader in wordDetailAction

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 2136

Show 611 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 04/10/24, 21:24

  2. core-ci voted on patch set 1 V -1 04/10/24, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55711

  3. Jasmina Ließmann uploaded patch set 2 V -1 04/11/24, 20:33

  4. core-ci voted on patch set 2 V +1 04/11/24, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55789

  5. Jasmina Ließmann uploaded patch set 3 V +1 04/11/24, 21:25

  6. core-ci voted on patch set 3 V +1 04/11/24, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55798

  7. Jasmina Ließmann uploaded patch set 4 V +1 04/11/24, 21:42

  8. core-ci voted on patch set 4 V +1 04/11/24, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55799

  9. Jasmina Ließmann updated the commit message in patch set 5 V +1 04/12/24, 09:34

  10. core-ci voted on patch set 5 V +1 04/12/24, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55847

  11. Jasmina Ließmann uploaded patch set 6 V +1 04/12/24, 13:14

  1. Jasmina Ließmann updated the commit message in patch set 7 04/12/24, 13:16

  2. core-ci voted on patch set 6 V -1 04/12/24, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55868

  3. core-ci voted on patch set 7 V -1 04/12/24, 13:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55869

  4. Jasmina Ließmann updated the commit message in patch set 8 V -1 04/12/24, 13:22

  5. Jasmina Ließmann uploaded patch set 9 04/12/24, 13:26

  6. core-ci voted on patch set 8 V -1 04/12/24, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55870

  7. core-ci voted on patch set 9 V +1 04/12/24, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55871

  8. Jasmina Ließmann uploaded patch set 10 V +1 04/17/24, 09:03

  9. core-ci voted on patch set 10 V +1 04/17/24, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56133

  10. Jasmina Ließmann uploaded patch set 11 V +1 04/17/24, 09:42

  11. Jasmina Ließmann updated the commit message in patch set 12 04/17/24, 09:44

  12. Jasmina Ließmann updated the commit message in patch set 13 04/17/24, 09:48

  13. core-ci voted on patch set 11 V +1 04/17/24, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56141

  14. core-ci voted on patch set 13 V +1 04/17/24, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56143

  15. core-ci voted on patch set 12 V +1 04/17/24, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56142

  16. Jasmina Ließmann updated the commit message in patch set 14 V +1 04/17/24, 10:22

  17. core-ci voted on patch set 14 V +1 04/17/24, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56148

  18. Christian Kuhn commented on patch set 14 04/17/24, 10:41

    Pages.html:39

    that's the type argument the page has been indexed with. let's keep it, at least for now.
  19. Jasmina Ließmann uploaded patch set 15 V +1 04/17/24, 10:46

  20. Jasmina Ließmann commented on patch set 15 04/17/24, 10:47

    Pages.html:39 Reply

    Done
  21. core-ci voted on patch set 15 V +1 04/17/24, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56150

  22. Christian Kuhn commented on patch set 15 CR +1 V +1 04/17/24, 10:58

    great general streamlining of the module.
  23. Georg Ringer voted on patch set 15 CR +1 V +1 04/17/24, 11:32

  24. Georg Ringer voted on patch set 15 CR +2 V +2 04/17/24, 11:32

  25. Georg Ringer merged patch set 16 04/17/24, 11:32