Review main Merged

83735[TASK] Increase RootlineUtility functional test coverage

Christian Kuhn CR +2 V +2 Hard +424 −189 updated 04/11/24, 08:31

Commit message

* Increase abstraction in imported CSV fixture to
  separate scenarios from each other.
* Turn single tests into a single test powered by
  a data provider.
* Add tests for pages['media'] relation resolving.
* Point out a bug related to a deleted workspace
  relation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 712

  1. Christian Kuhn uploaded patch set 1 04/11/24, 07:23

  2. core-ci voted on patch set 1 V +1 04/11/24, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55736

  3. Christian Kuhn uploaded patch set 2 V +1 04/11/24, 07:34

  4. core-ci voted on patch set 2 V +1 04/11/24, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55739

  5. Christian Kuhn uploaded patch set 3 V +1 04/11/24, 08:01

  6. core-ci voted on patch set 3 V +1 04/11/24, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55744

  7. core-ci voted on patch set 2 V -1 04/11/24, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55741

  8. core-ci voted on patch set 2 V +1 04/11/24, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55741

  9. Benni Mack voted on patch set 3 CR +1 V +1 04/11/24, 08:23

  10. Andreas Kienast voted on patch set 3 CR +1 V +1 04/11/24, 08:26

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 04/11/24, 08:31

  12. Christian Kuhn merged patch set 4 04/11/24, 08:31