Review main Merged

83741[TASK] Streamline Schema Parser test

Stefan Bürk CR +2 V +2 Hard +283 −254 updated 04/11/24, 10:39

Commit message

* Add variable names as dataprovider set
  array keys to increase readability.
* Add dataset for double-quote parsing in
  default values.
* Add a disabled dataset for single-quote
  parsing in default values with todo to
  enable it with the bugfix.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 04/11/24, 10:18

  2. core-ci voted on patch set 1 V +1 04/11/24, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55751

  3. Oliver Klee voted on patch set 1 CR +1 V +1 04/11/24, 10:26

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 04/11/24, 10:32

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 04/11/24, 10:32

  6. Stefan Bürk merged patch set 2 04/11/24, 10:39