Review main Merged

83742[BUGFIX] Cast simulated timestamp to int

Georg Ringer CR +2 V +2 Easy +2 −2 updated 04/12/24, 10:12

Commit message

`DateTimeImmutable::setTimestamp()` requires the timestamp to be an
integer.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Rafał Jania +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Rafał Jania +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 1416

  1. Georg Ringer uploaded patch set 1 04/11/24, 10:48

  2. Georg Ringer commented on patch set 1 04/11/24, 10:48

    This change is ready for review.
  3. Stefan Bürk voted on patch set 1 CR +1 V +1 04/11/24, 10:52

  4. core-ci voted on patch set 1 V +1 04/11/24, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55753

  5. Andreas Kienast voted on patch set 1 CR +1 04/11/24, 11:56

  6. Jörg Bösche voted on patch set 1 CR +1 04/11/24, 12:12

  7. Simon Schaufelberger commented on patch set 1 04/11/24, 15:25

    PreviewSimulator.php:163

    how about: `if ($queryTime === 0)`
  8. Stefan Bürk commented on patch set 2 CR +1 V +1 04/11/24, 18:39

    Published edit on patch set 1.
  9. Stefan Bürk commented on patch set 2 CR +1 V +1 04/11/24, 18:39

    PreviewSimulator.php:163 Reply

    Done
  10. Oliver Klee voted on patch set 2 CR +1 V +1 04/11/24, 18:42

  11. core-ci voted on patch set 2 V +1 04/11/24, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55787

  12. Simon Schaufelberger voted on patch set 2 CR +1 V +1 04/11/24, 19:59

  13. Rafał Jania voted on patch set 2 V +1 04/11/24, 20:55

  14. Rafał Jania voted on patch set 2 CR +1 04/11/24, 20:55

  15. Georg Ringer voted on patch set 2 CR +2 V +2 04/12/24, 10:12

  16. Georg Ringer merged patch set 3 04/12/24, 10:12