Review main Merged

83744[TASK] Separate StandardContentPreviewRenderer into smaller chunks

Benni Mack CR +2 V +2 Hard +151 −189 updated 06/14/24, 07:31

Commit message

The StandardContentPreviewRenderer has some quirks, which allows
to render the content via a Fluid Template via Page TSconfig.

mod.web_layout.tt_content.preview.textmedia = EXT:site_mysite/Resources/Private/Templates/Preview/Textmedia.html

This is now done via a PSR-14 EventListener. This was previously (back in v10)
not possible while the legacy "Page module" and the "Fluid-based" page module
existed and the PSR-14 event was not possible.

This way, the StandardContentPreviewRenderer is trimmed down.

Also, some additional logic is now restructured within the
StandardContentPreviewRenderer in order to separate the class
into smaller pieces.

Also, the TextmediaPreviewRenderer as well as the ImagePreviewRenderer
are not needed anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 2639

Show 814 earlier messages
  1. Benni Mack uploaded patch set 1 04/11/24, 11:10

  2. Benni Mack uploaded patch set 2 04/11/24, 11:14

  3. core-ci voted on patch set 1 V -1 04/11/24, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55759

  4. core-ci voted on patch set 2 V -1 04/11/24, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55760

  5. Benni Mack uploaded patch set 3 V -1 04/11/24, 11:23

  6. core-ci voted on patch set 3 V -1 04/11/24, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55761

  7. Benni Mack uploaded patch set 4 V -1 04/11/24, 11:35

  8. core-ci voted on patch set 4 V +1 04/11/24, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55767

  9. Nikita Hovratov commented on patch set 4 04/11/24, 12:18

    StandardContentPreviewRenderer.php:78

    Do you know what this variable is used for?
  10. Benni Mack uploaded patch set 5 V +1 04/12/24, 08:51

  11. Benni Mack commented on patch set 5 04/12/24, 08:51

    StandardContentPreviewRenderer.php:78 Reply

    good catch, we don't need it anymore.
  12. Benni Mack uploaded patch set 6 04/12/24, 08:53

  13. core-ci voted on patch set 6 V +1 04/12/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55838

  14. core-ci voted on patch set 5 V +1 04/12/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55837

  1. Georg Ringer commented on patch set 6 CR +1 V +1 04/12/24, 10:11

    FluidBasedContentPreviewRenderer.php:47

    just a nitpicking, shouldn't we call it $event?
  2. Benni Mack commented on patch set 7 CR +1 V +1 04/12/24, 10:47

    Published edit on patch set 6.
  3. Benni Mack commented on patch set 7 04/12/24, 10:48

    FluidBasedContentPreviewRenderer.php:47 Reply

    sry, fell back in my JS habit.
  4. Benni Mack commented on patch set 8 04/12/24, 10:48

    Published edit on patch set 7.
  5. core-ci voted on patch set 7 V +1 04/12/24, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55855

  6. core-ci voted on patch set 8 V +1 04/12/24, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55856

  7. Georg Ringer voted on patch set 8 CR +1 V +1 04/12/24, 11:18

  8. Nikita Hovratov commented on patch set 8 CR -1 04/13/24, 13:01

    BackendUtility.php:1169

    Do we really want to add a second (API) method, which is almost identical to `thumbCode`? I feel like this should not belong in this patch, as it is a new feature.
  9. Benni Mack uploaded patch set 9 CR +1 V +1 06/13/24, 17:53

  10. Benni Mack commented on patch set 9 06/13/24, 17:54

    BackendUtility.php:1169 Reply

    thanks. removed.
  11. core-ci voted on patch set 9 V +1 06/13/24, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59526

  12. Nikita Hovratov commented on patch set 9 CR -1 06/13/24, 20:46

    on it
  13. Nikita Hovratov uploaded patch set 10 CR -1 V +1 06/13/24, 21:07

  14. core-ci voted on patch set 10 V -1 06/13/24, 21:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59544

  15. Nikita Hovratov uploaded patch set 11 V -1 06/13/24, 21:24

  16. core-ci voted on patch set 11 V +1 06/13/24, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59545

  17. Nikita Hovratov uploaded patch set 12 V +1 06/13/24, 21:41

  18. Nikita Hovratov updated the commit message in patch set 13 06/13/24, 21:47

  19. Nikita Hovratov voted on patch set 13 CR +1 V +1 06/13/24, 21:47

  20. core-ci voted on patch set 12 V +1 06/13/24, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59546

  21. core-ci voted on patch set 13 V +1 06/13/24, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59547

  22. Andreas Kienast commented on patch set 13 V -1 06/14/24, 07:11

    With this patch, the image preview is missing from "image" elements. Is this intended?
  23. Andreas Kienast commented on patch set 13 CR +1 V +1 06/14/24, 07:21

    Never mind,

    Reply

    Never mind, my database state was inconsistent.
  24. Benni Mack voted on patch set 13 CR +2 V +2 06/14/24, 07:31

  25. Benni Mack merged patch set 14 06/14/24, 07:31