83744[TASK] Separate StandardContentPreviewRenderer into smaller chunks
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Nikita Hovratov +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Nikita Hovratov +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/backend/Classes/Preview/FluidBasedContentPreviewRenderer.php2new+117 −0
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php2+27 −105
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+1 −1
- typo3/sysext/backend/Classes/View/Event/PageContentPreviewRenderingEvent.php+6 −0
- typo3/sysext/frontend/Classes/Preview/ImagePreviewRenderer.phpdeleted+0 −37
- typo3/sysext/frontend/Classes/Preview/TextmediaPreviewRenderer.phpdeleted+0 −44
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+0 −2
Review log 2639
Show 814 earlier messages
-
Benni Mack uploaded patch set 1 04/11/24, 11:10
-
Benni Mack uploaded patch set 2 04/11/24, 11:14
-
core-ci voted on patch set 1 V -1 04/11/24, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55759
-
core-ci voted on patch set 2 V -1 04/11/24, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55760
-
Benni Mack uploaded patch set 3
V -104/11/24, 11:23 -
core-ci voted on patch set 3 V -1 04/11/24, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55761
-
Benni Mack uploaded patch set 4
V -104/11/24, 11:35 -
core-ci voted on patch set 4 V +1 04/11/24, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55767
-
Nikita Hovratov commented on patch set 4 04/11/24, 12:18
-
Benni Mack uploaded patch set 5
V +104/12/24, 08:51 -
Benni Mack commented on patch set 5 04/12/24, 08:51
StandardContentPreviewRenderer.php:78Replygood catch, we don't need it anymore. -
Benni Mack uploaded patch set 6 04/12/24, 08:53
-
core-ci voted on patch set 6 V +1 04/12/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55838
-
core-ci voted on patch set 5 V +1 04/12/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55837
-
Georg Ringer commented on patch set 6 CR +1 V +1 04/12/24, 10:11
FluidBasedContentPreviewRenderer.php:47just a nitpicking, shouldn't we call it $event? -
Benni Mack commented on patch set 7
CR +1V +104/12/24, 10:47Published edit on patch set 6. -
Benni Mack commented on patch set 7 04/12/24, 10:48
FluidBasedContentPreviewRenderer.php:47Replysry, fell back in my JS habit. -
Benni Mack commented on patch set 8 04/12/24, 10:48
Published edit on patch set 7. -
core-ci voted on patch set 7 V +1 04/12/24, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55855
-
core-ci voted on patch set 8 V +1 04/12/24, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55856
-
Georg Ringer voted on patch set 8 CR +1 V +1 04/12/24, 11:18
-
Nikita Hovratov commented on patch set 8 CR -1 04/13/24, 13:01
BackendUtility.php:1169Do we really want to add a second (API) method, which is almost identical to `thumbCode`? I feel like this should not belong in this patch, as it is a new feature. -
Benni Mack uploaded patch set 9
CR +1V +106/13/24, 17:53 -
Benni Mack commented on patch set 9 06/13/24, 17:54
BackendUtility.php:1169Replythanks. removed. -
core-ci voted on patch set 9 V +1 06/13/24, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59526
-
Nikita Hovratov commented on patch set 9 CR -1 06/13/24, 20:46
on it -
Nikita Hovratov uploaded patch set 10
CR -1V +106/13/24, 21:07 -
core-ci voted on patch set 10 V -1 06/13/24, 21:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59544
-
Nikita Hovratov uploaded patch set 11
V -106/13/24, 21:24 -
core-ci voted on patch set 11 V +1 06/13/24, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59545
-
Nikita Hovratov uploaded patch set 12
V +106/13/24, 21:41 -
Nikita Hovratov updated the commit message in patch set 13 06/13/24, 21:47
-
Nikita Hovratov voted on patch set 13 CR +1 V +1 06/13/24, 21:47
-
core-ci voted on patch set 12 V +1 06/13/24, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59546
-
core-ci voted on patch set 13 V +1 06/13/24, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59547
-
Andreas Kienast commented on patch set 13 V -1 06/14/24, 07:11
With this patch, the image preview is missing from "image" elements. Is this intended? -
Andreas Kienast commented on patch set 13 CR +1 V +1 06/14/24, 07:21
Never mind,Reply
Never mind, my database state was inconsistent. -
Benni Mack voted on patch set 13 CR +2 V +2 06/14/24, 07:31
-
Benni Mack merged patch set 14 06/14/24, 07:31
StandardContentPreviewRenderer.php:78