Review main Merged

83746[TASK] Enable corrected test for default value parsing

Stefan Bürk CR +2 V +2 Easy +15 −15 updated 04/11/24, 18:32

Commit message

Test covering the SQL file parser has been streamlined
and enriched with #103602, adding a disabled test with
a todo to enable it when the SuT is fixed.

Turns out the parser already handles the case well,
the patch just enables the test.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Stefan Bürk uploaded patch set 1 04/11/24, 11:43

  2. core-ci voted on patch set 1 V +1 04/11/24, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55768

  3. Christian Kuhn updated the commit message in patch set 2 V +1 04/11/24, 15:11

  4. Christian Kuhn voted on patch set 2 CR +1 V +1 04/11/24, 15:11

  5. core-ci voted on patch set 2 V +1 04/11/24, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55778

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 04/11/24, 15:22

  7. Garvin Hicking voted on patch set 2 CR +1 V +1 04/11/24, 15:41

  8. Oliver Klee voted on patch set 2 CR +1 V +1 04/11/24, 17:01

  9. Stefan Bürk voted on patch set 2 CR +2 V +2 04/11/24, 18:31

  10. Stefan Bürk merged patch set 3 04/11/24, 18:32