Review main Merged

83748[TASK] Replace `stylefmt` with `stylelint`

Andreas Kienast CR +2 V +2 Hard +105 −270 updated 04/12/24, 09:12

Commit message

This commit replaces the abandoned package `@ronilaukkarinen/stylefmt`
with the already installed `stylelint` tool.

Please note that this is an intermediate step to give the build
toolchain some love it deserves.

Executed commands:

    npm remove @ronilaukkarinen/stylefmt
    npm install --save-dev \
        autoprefixer@^10.4.19 \
        postcss-scss@^4.0.9 \
        stylelint@^14.16.1 \
        stylelint-scss@^5.3.1

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Willi Wehmeier +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Willi Wehmeier +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1116

  1. Andreas Kienast uploaded patch set 1 04/11/24, 16:23

  2. core-ci voted on patch set 1 V -1 04/11/24, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55779

  3. Andreas Kienast uploaded patch set 2 V -1 04/11/24, 16:42

  4. core-ci voted on patch set 2 V -1 04/11/24, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55780

  5. Andreas Kienast uploaded patch set 3 V -1 04/11/24, 20:06

  6. Andreas Kienast voted on patch set 3 CR -2 04/11/24, 20:06

  7. core-ci voted on patch set 3 V +1 04/11/24, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55788

  8. Andreas Kienast voted on patch set 3 CR 0 04/11/24, 20:57

  9. Andreas Kienast uploaded patch set 4 V +1 04/11/24, 20:58

  10. core-ci voted on patch set 4 V +1 04/11/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55792

  11. Andreas Kienast updated the commit message in patch set 5 V +1 04/11/24, 21:13

  12. core-ci voted on patch set 5 V +1 04/11/24, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55797

  13. Willi Wehmeier commented on patch set 5 CR +1 V +1 04/12/24, 08:48

    Does work and fixes the build issue mentioned in https://review.typo3.org/c/Packages/TYPO3.CMS/+/83566
  14. Benni Mack voted on patch set 5 CR +1 V +1 04/12/24, 08:53

  15. Andreas Kienast voted on patch set 5 CR +2 V +2 04/12/24, 09:12

  16. Andreas Kienast merged patch set 6 04/12/24, 09:12