Review main Merged

83750[TASK] Align to phpdocumentor/reflection-docblock:5.4.0

Christian Kuhn CR +2 V +2 Easy +22 −27 updated 04/12/24, 11:00

Commit message

New version phpdocumentor/reflection-docblock:5.4.0
changed the signature of DocBlockFactory::createInstance(),
which now points out a misuse in extbase.

The patch changes the instantiation and avoids
calling registerTagHandler() since this can and
should be hand over to createInstance() directly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 712

  1. Christian Kuhn uploaded patch set 1 04/12/24, 06:58

  2. core-ci voted on patch set 1 V +1 04/12/24, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55833

  3. core-ci commented on patch set 1 04/12/24, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55836

  4. Christian Kuhn updated the commit message in patch set 2 V +1 04/12/24, 09:02

  5. core-ci voted on patch set 2 V +1 04/12/24, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55840

  6. Andreas Kienast voted on patch set 2 CR +1 04/12/24, 09:13

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 04/12/24, 09:27

  8. core-ci voted on patch set 2 V -1 04/12/24, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55842

  9. core-ci voted on patch set 2 V +1 04/12/24, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55842

  10. Benni Mack voted on patch set 2 CR +1 V +1 04/12/24, 10:51

  11. Christian Kuhn voted on patch set 2 CR +2 V +2 04/12/24, 11:00

  12. Christian Kuhn merged patch set 3 04/12/24, 11:00