83774[BUGFIX] Do not log failed HMAC validations for HashService
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christoph Lehmann +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christoph Lehmann +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1416
-
Torben Hansen uploaded patch set 1 04/12/24, 12:32
-
core-ci voted on patch set 1 V +1 04/12/24, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55865
-
Torben Hansen commented on patch set 1 04/12/24, 14:13
Note, if we apply this to v12, the change must be adapted to exclude v13 exception codes for core HashService and the not in extbase HashService must be removed. -
Oliver Klee voted on patch set 1 CR +1 04/12/24, 14:16
-
Stefan Bürk voted on patch set 1 CR +1 V +1 04/12/24, 14:30
-
Simon Schaufelberger voted on patch set 1 CR +1 V +1 04/12/24, 14:50
-
Christoph Lehmann commented on patch set 1 CR +1 V +1 04/12/24, 14:55
👍 -
Stefan Bürk commented on patch set 1 CR -1 04/14/24, 16:50
error in releases line -
Stefan Bürk updated the commit message in patch set 2
CR +1V +104/14/24, 16:50 -
Stefan Bürk commented on patch set 2 CR +1 V +1 04/14/24, 16:50
Reply
Done -
core-ci voted on patch set 2 V +1 04/14/24, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55954
-
Oliver Klee voted on patch set 2 CR +1 04/14/24, 17:43
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 04/14/24, 18:46
-
Christoph Lehmann voted on patch set 2 CR +1 V +1 04/15/24, 07:36
-
Stefan Bürk voted on patch set 2 CR +2 V +2 04/16/24, 06:58
-
Stefan Bürk merged patch set 3 04/16/24, 07:06