83775[FEATURE] Add versionNumber attribute to f:uri.resource view helper
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1013
-
Christian Weiske uploaded patch set 1 04/12/24, 12:36
-
core-ci voted on patch set 1 V +1 04/12/24, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55866
-
Chris Müller commented on patch set 1 CR -1 04/13/24, 17:04
A feature RST is missing: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/AddingDocumentation/Index.html -
Christian Weiske uploaded patch set 2
CR -1V +104/16/24, 08:40 -
Christian Weiske commented on patch set 2 04/16/24, 08:41
Reply
Done -
Benni Mack commented on patch set 2 04/16/24, 08:43
I think we should enable this option by default. WDYT? -
Benni Mack commented on patch set 2 04/16/24, 08:44
-
Christian Weiske commented on patch set 2 04/16/24, 08:45
Reply
This option makes sense for generated files that change now and then, but not for static files like images that never change. So enabling it by default is not useful in my eyes. -
core-ci voted on patch set 2 V +1 04/16/24, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56065
-
Christian Weiske rebased onto patch set 3
V +104/29/24, 16:43 -
core-ci voted on patch set 3 V +1 04/29/24, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56971
-
Guido Schmechel commented on patch set 3 05/04/24, 18:24
Feature exists in https://review.typo3.org/c/Packages/TYPO3.CMS/+/77018, too -
Georg Ringer abandoned the change 06/25/24, 12:49
I abandon the change in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/77018