Review main Abandoned

83775[FEATURE] Add versionNumber attribute to f:uri.resource view helper

Christian Weiske CR 0 V 0 Easy +48 −0 updated 06/25/24, 12:49

Commit message

The optional argument adds a cache-busting GET parameter to URIs
generated with <f:uri.resource>.
URLs generated look like "/path/to/file.svg?1685042023".

The "versionNumberInFilename" configuration setting must be enabled
for this to work.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1013

  1. Christian Weiske uploaded patch set 1 04/12/24, 12:36

  2. core-ci voted on patch set 1 V +1 04/12/24, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55866

  3. Chris Müller commented on patch set 1 CR -1 04/13/24, 17:04

  4. Christian Weiske uploaded patch set 2 CR -1 V +1 04/16/24, 08:40

  5. Christian Weiske commented on patch set 2 04/16/24, 08:41

    Reply

    Done
  6. Benni Mack commented on patch set 2 04/16/24, 08:43

    I think we should enable this option by default. WDYT?
  7. Benni Mack commented on patch set 2 04/16/24, 08:44

  8. Christian Weiske commented on patch set 2 04/16/24, 08:45

    Reply

    This option makes sense for generated files that change now and then, but not for static files like images that never change. So enabling it by default is not useful in my eyes.
  9. core-ci voted on patch set 2 V +1 04/16/24, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56065

  10. Christian Weiske rebased onto patch set 3 V +1 04/29/24, 16:43

  11. core-ci voted on patch set 3 V +1 04/29/24, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56971

  12. Guido Schmechel commented on patch set 3 05/04/24, 18:24

  13. Georg Ringer abandoned the change 06/25/24, 12:49