Review main Merged

83777[BUGFIX] Use correct `resname` attribute in xlf file of EXT:dashboard

Jasmina Ließmann CR +2 V +2 Easy +1 −1 updated 04/13/24, 08:20

Commit message

The patch for #103615 added `resname` attributes to EXT:dashboard
locallang files. An attribute was used twice, this is hereby corrected.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Jasmina Ließmann uploaded patch set 1 04/12/24, 19:10

  2. Simon Schaufelberger voted on patch set 1 CR +1 V +1 04/12/24, 19:15

  3. Simon Schaufelberger commented on patch set 1 04/12/24, 19:16

    the bug is also for v11. consider a backport?
  4. core-ci voted on patch set 1 V +1 04/12/24, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55877

  5. Jasmina Ließmann commented on patch set 1 04/12/24, 19:20

    Reply

    The v11 patchset has not been merged yet. I updated the v11 backport accordingly (https://review.typo3.org/c/Packages/TYPO3.CMS/+/83759).
  6. Andreas Kienast voted on patch set 1 CR +2 V +2 04/13/24, 08:13

  7. Andreas Kienast merged patch set 2 04/13/24, 08:20