83778[TASK] Center Install Tool cards horizontally
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/install/Classes/Controller/AbstractController.php+1 −0
- typo3/sysext/install/Resources/Private/Layouts/Cards.htmlnew+7 −0
- typo3/sysext/install/Resources/Private/Templates/Environment/Cards.html+12 −12
- typo3/sysext/install/Resources/Private/Templates/Maintenance/Cards.html+14 −14
- typo3/sysext/install/Resources/Private/Templates/Settings/Cards.html+15 −13
- typo3/sysext/install/Resources/Private/Templates/Upgrade/Cards.html+13 −13
Review log 2632
Show 57 earlier messages
-
Andreas Kienast uploaded patch set 1 04/13/24, 12:18
-
core-ci voted on patch set 1 V +1 04/13/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55910
-
Stefan Bürk updated the commit message in patch set 2
V +104/14/24, 16:48 -
core-ci voted on patch set 2 V +1 04/14/24, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55953
-
Georg Ringer voted on patch set 2 CR +1 V +1 04/15/24, 05:18
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 04/15/24, 09:26
-
Oli Bartsch voted on patch set 2 CR +1 V +1 04/15/24, 16:32
-
Stefan Bürk voted on patch set 2 CR +1 V +1 04/15/24, 20:13
-
Benjamin Franzke commented on patch set 2 V -1 04/22/24, 07:20
Seems there is no max-width defined for wide monitors. Text/cards become too wide: https://bnf.dev/~ben/uploads/5a432/screenshot-t3core.local-2024.04.22-09_19_24.png -
Oli Bartsch commented on patch set 2 04/22/24, 07:40
Reply
Actually I though that this is the intended behaviour. -
Andreas Kienast commented on patch set 2 04/22/24, 07:54
Reply
Yes, but not THAT huge 😄 -
Christian Kuhn commented on patch set 2 04/23/24, 00:10
Reply
Agree to Benjamin. Current patch version feels odd to me: I think the intended behavior of the cards at this point is to a) have a fixed width, and b) float, so typically something between 2 to 6 are shown next to each other. I guess Benji Kott wouldn't like this solution much, either. -
Stefan Bürk voted on patch set 2 CR 0 V 0 04/23/24, 00:17
-
Andreas Kienast uploaded patch set 3
CR +1V +105/22/24, 09:27 -
core-ci voted on patch set 3 V +1 05/22/24, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58042
-
Andreas Kienast updated the commit message in patch set 4
V +105/22/24, 12:43 -
core-ci voted on patch set 4 V +1 05/22/24, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58053
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 05/22/24, 13:46
-
Simon Schaufelberger commented on patch set 4 05/22/24, 13:48
Please adjust the original issue as well as they are out of sync as the implementation is totally different as the issue now. -
Andreas Kienast commented on patch set 4 05/23/24, 07:16
Reply
We never did that in the past, neither in our tickets, nor in tickets from non-mergers. It's completely fine to have a different solution as initially proposed in the ticket, the patch's evolution can be seen in Gerrit. -
Andreas Nedbal voted on patch set 4 CR +1 V +1 05/24/24, 08:21
-
Georg Ringer voted on patch set 4 CR +1 V +1 05/24/24, 08:22
-
Jasmina Ließmann voted on patch set 4 CR +1 V +1 05/25/24, 11:57
-
Jasmina Ließmann commented on patch set 4 05/25/24, 12:48
Reply
@ben@bnf.dev What do you think about the current implementation? -
Benjamin Franzke uploaded patch set 5
CR +1V +105/31/24, 08:18 -
Benjamin Franzke commented on patch set 5 05/31/24, 08:18
Reply
I like (only changed the structure to reduce the diff and make this less-annoying for `git blame` usage). -
Benjamin Franzke uploaded patch set 6
CR +1V +105/31/24, 08:19 -
core-ci voted on patch set 5 V -1 05/31/24, 08:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58527
-
core-ci voted on patch set 6 V +1 05/31/24, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58528
-
Georg Ringer voted on patch set 6 CR +1 V +1 06/04/24, 11:56
-
Benjamin Franzke voted on patch set 6 CR +2 V +2 06/04/24, 14:24
-
Benjamin Franzke merged patch set 7 06/04/24, 14:24