Review main Abandoned

83779[TASK] Exclude Tests folder from maxFilePathLength check

Nikita Hovratov CR 0 V 0 Easy +1 −1 updated 04/16/24, 12:04

Commit message

Test folders are not packaged and thus should not be checked
for maximum file path length.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 78

  1. Nikita Hovratov uploaded patch set 1 04/13/24, 12:40

  2. core-ci voted on patch set 1 V +1 04/13/24, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55912

  3. Oli Bartsch commented on patch set 1 04/16/24, 09:21

    I think the check should not only apply for files getting packaged. I mean, why should we want to have test files with more than 160 chars. Readability should also be considered for test files. What do you think?
  4. Christian Kuhn commented on patch set 1 CR -1 04/16/24, 10:33

    not checking that path length is an issue when people develop core on windows.
  5. Christian Kuhn commented on patch set 1 04/16/24, 10:34

    Reply

    'path length for Tests dirs'
  6. Nikita Hovratov commented on patch set 1 04/16/24, 10:40

    Reply

    ack
  7. Nikita Hovratov abandoned the change 04/16/24, 10:40

    keep for dear windows developers
  8. Nikita Hovratov commented on patch set 1 04/16/24, 12:04

    Reply Unresolved

    Hi Oli, this is about the full path length, not the file length of individual files. I had now a case, where some fixture files exceeded this limit. Now I need to move them higher up, where they actually don't belong. But as lolli said, we don't want to break things for windows developers.