83781[BUGFIX] Hide hidden content elements in page module
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Willi Wehmeier +1
-
Verified V +2 Done
- Oli Bartsch +2
- Willi Wehmeier +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1523
-
Ayke Halder uploaded patch set 1 04/14/24, 11:10
-
core-ci voted on patch set 1 V +1 04/14/24, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55942
-
Ayke Halder uploaded patch set 2
V +104/14/24, 13:10 -
Ayke Halder uploaded patch set 3 04/14/24, 13:13
-
core-ci voted on patch set 2 V -1 04/14/24, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55950
-
core-ci voted on patch set 3 V +1 04/14/24, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55951
-
Oli Bartsch commented on patch set 3 V -1 04/16/24, 09:10
This already improves the functionality a lot. However I still encounter strange behaviour under some circumstances. Send you a screenshot in Slack. -
Ayke Halder uploaded patch set 4
V +104/16/24, 14:08 -
core-ci voted on patch set 4 V +1 04/16/24, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56089
-
Ayke Halder commented on patch set 4 04/16/24, 14:15
Reply
If the URLs anchor-part is set to the elements id, the element gets a scroll-correcting pseudo-element by CSS: `:target:before` This pseudo-element has a height which is countered by negative margin-top. `scrollHeight` and `height` of the element are still influenced by this pseudo-element and the elements `margin-top`. So in case you toggle the visible state of an element the url becomes: https://typo3.ddev.site/typo3/module/web/layout?id=2#element-tt_content-5 Then switch the 'show hidden elements' checkbox and this element referenced by the URL-anchor behaves broken. -
Ayke Halder uploaded patch set 5
V +104/16/24, 15:38 -
Ayke Halder commented on patch set 5 04/16/24, 15:40
Reply
Fixed by using `overflow: clip` in combination with `display: flow-root`. Also see https://developer.mozilla.org/en-US/docs/Web/CSS/display#flow-root -
Ayke Halder uploaded patch set 6 04/16/24, 15:43
-
core-ci voted on patch set 5 V -1 04/16/24, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56093
-
core-ci voted on patch set 6 V -1 04/16/24, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56094
-
Ayke Halder uploaded patch set 7
V -104/16/24, 16:22 -
core-ci voted on patch set 7 V +1 04/16/24, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56095
-
Ayke Halder uploaded patch set 8
V +104/16/24, 16:57 -
core-ci voted on patch set 8 V +1 04/16/24, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56096
-
Oli Bartsch voted on patch set 8 CR +1 V +1 04/17/24, 07:08
-
Willi Wehmeier voted on patch set 8 CR +1 V +1 04/23/24, 09:12
-
Oli Bartsch voted on patch set 8 CR +2 V +2 04/23/24, 13:50
-
Oli Bartsch merged patch set 9 04/23/24, 13:50