Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
83785[FEATURE] Support doktype, module and slug in page tree filter
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 9
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/85/83785/9 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/85/83785/9 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeFilter.php+47 −0
- typo3/sysext/backend/Tests/Functional/Tree/Repository/Fixtures/PageTree.csv+16 −12
- typo3/sysext/backend/Tests/Functional/Tree/Repository/PageTreeRepositoryTest.php+129 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-103253-SupportDoktypeModuleAndSlugInPageTreeFilter.rstnew+41 −0
Review log 2938
Show 913 earlier messages
-
Philipp Kitzberger uploaded patch set 1 04/15/24, 09:36
-
core-ci voted on patch set 1 V -1 04/15/24, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55987
-
Philipp Kitzberger uploaded patch set 2
V -104/15/24, 10:26 -
core-ci voted on patch set 2 V +1 04/15/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55988
-
Chris Müller commented on patch set 2 CR -1 04/15/24, 12:14
Impact is missing in changelog. -
Stefan Bürk commented on patch set 2 04/16/24, 08:00
PageTreeRepository.php:579special keyword filter handlings are not removed from `$searchFilter` ending up as `LIKE` query below. This looks dirty. I'd say we need to remove all of the 3 special keyword handling from search string. What do you think ?Feature-103253-SupportDoktypeModuleAndSlugInPageTreeFilter.rst:32using the special keys as like filter literally does not make any sense. This should be prevented AND not stated as "feature". -
Philipp Kitzberger commented on patch set 2 04/16/24, 10:18
Feature-103253-SupportDoktypeModuleAndSlugInPageTreeFilter.rst:32ReplyI admit it's odd that this reads as a feature. But: in theory a page could be named `module:...` and wouldn't be found anymore strip off the keyword or bypass that LIKE-block. Hence my approach of fully documenting what's happening under the hood. -
Garvin Hicking uploaded patch set 3
CR -1V +106/13/24, 11:49Move RST adjust commit message -
Garvin Hicking commented on patch set 3 06/13/24, 11:51
Rebased and moved Changelog RST to 13.2 I think this would be a cool patch to wrap up :)Feature-103253-SupportDoktypeModuleAndSlugInPageTreeFilter.rst:32ReplyI agree that it should still be possible to find pages called "module:news" by their title, and not only by "module" = "news". However one question: Shouldn't the search actually perform: doktype=254 **OR** title LIKE OR nav_title like? Because when I enter "doktype=254" I would fand the page list to show all pages that meet the "doktype=254" criteria, but currently it would only show these with a title/nav_title "doktype=254" which wouldn't be a common result. ;) Same with slug - you want to filter by slug and not additionally meeting the "title/nav_title" criteria?! -
core-ci voted on patch set 3 V +1 06/13/24, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59474
-
Philipp Kitzberger uploaded patch set 4
V +106/15/24, 09:33 -
Philipp Kitzberger commented on patch set 4 06/15/24, 09:36
Feature-103253-SupportDoktypeModuleAndSlugInPageTreeFilter.rst:32Reply@gh@faktor-e.de you're right. The was a typo in the rst file that I've fixed with the 4th revision of the patch. -
core-ci voted on patch set 4 V +1 06/15/24, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59640
-
Philipp Kitzberger commented on patch set 4 10/11/24, 10:07
PageTreeRepository.php:579Reply@stefan@buerk.tech, this would make it impossible to search for a page titled "module:something". It's not that unlikely to have a page title like that. So I would argue it's always better to include the user input "as is" in the search string. -
Guido Schmechel commented on patch set 4 10/12/24, 12:10
Does it make sense to think about an event here? Then you would have full freedom from the developer's point of view. The current code status could be stored in the RST as an example? -
Garvin Hicking commented on patch set 4 01/14/25, 10:23
Reply
This has actually been achieved with https://forge.typo3.org/issues/105833 @typo3@kitze.net would you be interested to adapt your patch to use that event? -
Chris Müller wrote 01/14/25, 18:16
Removed reviewer Chris Müller. -
Benni Mack commented on patch set 4 03/28/25, 12:12
waiting for feedback here, putting this change into WIP. -
Benni Mack marked it work in progress 03/28/25, 12:12
-
Philipp Kitzberger uploaded patch set 5
V +103/29/25, 09:31 -
core-ci voted on patch set 5 V +1 03/29/25, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76632
-
Philipp Kitzberger uploaded patch set 6
V +103/29/25, 09:51 -
core-ci voted on patch set 6 V +1 03/29/25, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76633
-
Garvin Hicking commented on patch set 6 03/29/25, 10:22
Awesome thanks for picking it up! Would you be interested to include https://review.typo3.org/c/Packages/TYPO3.CMS/+/87549 in your patch? Maybe with a "url:" prefix to be in line with your prefixes....? (Otherwise I could either try myself to integrate it, or we keep it seperately and I use the PSR event for it) -
Philipp Kitzberger commented on patch set 6 03/31/25, 07:04
This change is ready for review.Reply
You mean that in addition to searching via "slug:/my-page/my-subpage" absolute URLs should be processed as well? I like that idea. Don't know if that should be part of this PR though. This patch focuses on fields of the page record while 87549 seems to do a lot more than that. -
Garvin Hicking commented on patch set 6 03/31/25, 08:04
Reply
OK sure, no worries then if you feel this leaves the scope of your patch. I feel its pretty similar, but when your patch can get merged it can be the foundation for this idea as a follow-up. Could you adjust the feature RST to 14.0? -
Georg Ringer uploaded patch set 7
V +103/31/25, 13:45 -
core-ci voted on patch set 7 V +1 03/31/25, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76723
-
Garvin Hicking commented on patch set 7 11/11/25, 12:49
Reply
Marking as resolved. "My" patch can be a follow-up. Should not be integrated here I agree now 😄PageTreeRepository.php:579Reply Unresolved(this here might still debatable, don't know?!)Feature-103253-SupportDoktypeModuleAndSlugInPageTreeFilter.rst:32ReplyDone -
Andreas Nedbal voted on patch set 7 CR +1 V +1 11/11/25, 14:04
-
Garvin Hicking voted on patch set 7 CR +1 V +1 11/11/25, 22:53
-
Oli Bartsch commented on patch set 7 V -1 12/05/25, 10:08
Unresolved
Let's look at this in more detail please. And first get the general rework merged first: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91402. -
Simon Schaufelberger uploaded patch set 8
CR +1V +101/21/26, 23:26 -
core-ci voted on patch set 8 V -1 01/21/26, 23:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93984
-
Simon Schaufelberger rebased onto patch set 9
V -101/22/26, 06:53 -
core-ci voted on patch set 9 V +1 01/22/26, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94010
-
Garvin Hicking commented on patch set 9 02/20/26, 09:16
@typo3@kitze.net As you may have seen, v14 received "love" in this regard and new event listeners and "structure" was added to have better reactions to filters. Are you interested in picking this up and modifying your patch to accommodate the recent changes? -
Garvin Hicking marked it work in progress 04/14/26, 19:13