83834[TASK] Add missing aria-label to record icons
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- Jörg Bösche +1
-
Verified V +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1723
-
Willi Wehmeier uploaded patch set 1 04/16/24, 07:50
-
core-ci voted on patch set 1 V -1 04/16/24, 07:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56056
-
core-ci commented on patch set 1 04/16/24, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56056
-
Willi Wehmeier uploaded patch set 2
V -104/16/24, 08:29 -
core-ci voted on patch set 2 V +1 04/16/24, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56061
-
Oli Bartsch commented on patch set 2 04/16/24, 09:13
-
Andreas Kienast commented on patch set 2 04/16/24, 09:21
BackendUtility.php:1995ReplyI assume for backwards compat, otherwise this might be a breaking change. -
Willi Wehmeier commented on patch set 2 04/16/24, 09:22
BackendUtility.php:1995ReplyWould it be preferred to set an empty array as a default? -
Willi Wehmeier commented on patch set 2 04/16/24, 09:23
BackendUtility.php:1995ReplyThe row isn't available in all cases, that's why it must be optional 😊 -
Oli Bartsch commented on patch set 2 04/18/24, 07:12
BackendUtility.php:1995ReplySince this is a new argument, I don't see why this should be a breaking change. Would prefer to have this initialized with an empty array. Calling code should ensure, given $row is an array. -
Willi Wehmeier uploaded patch set 3
V +104/18/24, 07:17 -
core-ci voted on patch set 3 V +1 04/18/24, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56220
-
Oli Bartsch commented on patch set 3 04/18/24, 07:32
Should start with a capital letter.BackendUtility.php:1999Please also add a type hint for the new argument. -
Willi Wehmeier uploaded patch set 4
V +104/18/24, 07:36 -
core-ci voted on patch set 4 V +1 04/18/24, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56227
-
Oli Bartsch uploaded patch set 5
V +104/18/24, 07:47 -
Oli Bartsch commented on patch set 5 04/18/24, 07:51
Reply
DoneBackendUtility.php:1995ReplyDoneBackendUtility.php:1999ReplyDone -
core-ci voted on patch set 5 V +1 04/18/24, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56229
-
Oli Bartsch voted on patch set 5 CR +1 V +1 04/18/24, 08:21
-
Jörg Bösche voted on patch set 5 CR +1 04/19/24, 12:25
-
Andreas Kienast voted on patch set 5 CR +1 V +1 04/22/24, 07:56
-
Oli Bartsch voted on patch set 5 CR +2 V +2 04/22/24, 08:30
-
Oli Bartsch merged patch set 6 04/22/24, 08:30
BackendUtility.php:1995