Review main Merged

83834[TASK] Add missing aria-label to record icons

Willi Wehmeier CR +2 V +2 Easy +35 −7 updated 04/22/24, 08:30

Commit message

Add accessible aria-labels to the record icon
located in the docheader component on the upper
right. Additionally the record icon on the
bottom right below the edit record form has got
an aria-label now.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1723

  1. Willi Wehmeier uploaded patch set 1 04/16/24, 07:50

  2. core-ci voted on patch set 1 V -1 04/16/24, 07:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56056

  3. core-ci commented on patch set 1 04/16/24, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56056

  4. Willi Wehmeier uploaded patch set 2 V -1 04/16/24, 08:29

  5. core-ci voted on patch set 2 V +1 04/16/24, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56061

  6. Oli Bartsch commented on patch set 2 04/16/24, 09:13

    BackendUtility.php:1995

    Why do we need this new argument be nullable?
  7. Andreas Kienast commented on patch set 2 04/16/24, 09:21

    BackendUtility.php:1995 Reply

    I assume for backwards compat, otherwise this might be a breaking change.
  8. Willi Wehmeier commented on patch set 2 04/16/24, 09:22

    BackendUtility.php:1995 Reply

    Would it be preferred to set an empty array as a default?
  9. Willi Wehmeier commented on patch set 2 04/16/24, 09:23

    BackendUtility.php:1995 Reply

    The row isn't available in all cases, that's why it must be optional 😊
  10. Oli Bartsch commented on patch set 2 04/18/24, 07:12

    BackendUtility.php:1995 Reply

    Since this is a new argument, I don't see why this should be a breaking change. Would prefer to have this initialized with an empty array. Calling code should ensure, given $row is an array.
  11. Willi Wehmeier uploaded patch set 3 V +1 04/18/24, 07:17

  12. core-ci voted on patch set 3 V +1 04/18/24, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56220

  13. Oli Bartsch commented on patch set 3 04/18/24, 07:32

    Should start with a capital letter.

    BackendUtility.php:1999

    Please also add a type hint for the new argument.
  14. Willi Wehmeier uploaded patch set 4 V +1 04/18/24, 07:36

  15. core-ci voted on patch set 4 V +1 04/18/24, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56227

  16. Oli Bartsch uploaded patch set 5 V +1 04/18/24, 07:47

  17. Oli Bartsch commented on patch set 5 04/18/24, 07:51

    Reply

    Done

    BackendUtility.php:1995 Reply

    Done

    BackendUtility.php:1999 Reply

    Done
  18. core-ci voted on patch set 5 V +1 04/18/24, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56229

  19. Oli Bartsch voted on patch set 5 CR +1 V +1 04/18/24, 08:21

  20. Jörg Bösche voted on patch set 5 CR +1 04/19/24, 12:25

  21. Andreas Kienast voted on patch set 5 CR +1 V +1 04/22/24, 07:56

  22. Oli Bartsch voted on patch set 5 CR +2 V +2 04/22/24, 08:30

  23. Oli Bartsch merged patch set 6 04/22/24, 08:30