Review 12.4 Merged

83838[BUGFIX] Avoid "Save changes and view" in FormEngine if form is invalid

Andreas Kienast CR +2 V +2 Normal +54 −25 updated 04/07/25, 13:20

Commit message

The implementation of the "Save changes and view" modal triggered in
FormEngine via the "View" button is prone to data inconsistency as it
may save the form and bypass the FormEngine validation.

The "View" modal now checks whether the current FormEngine state is
invalid and therefore won't render the "Save changes and view" button.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 1217

  1. Andreas Kienast uploaded patch set 1 04/16/24, 14:37

  2. core-ci voted on patch set 1 V +1 04/16/24, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56091

  3. Andreas Kienast uploaded patch set 2 V +1 09/10/24, 13:15

  4. core-ci voted on patch set 2 V +1 09/10/24, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65250

  5. Andreas Kienast rebased onto patch set 3 V +1 09/25/24, 13:35

  6. core-ci voted on patch set 3 V +1 09/25/24, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66588

  7. Andreas Kienast abandoned the change 10/14/24, 19:19

  8. Andreas Kienast restored the change 11/04/24, 07:54

  9. Andreas Kienast uploaded patch set 4 V +1 11/04/24, 07:55

  10. core-ci voted on patch set 4 V +1 11/04/24, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69017

  11. Benjamin Franzke marked it work in progress 11/04/24, 10:25

  12. Benjamin Franzke commented on patch set 4 11/04/24, 10:25

    Marking as WIP until the `main` patch is reviewed
  13. Andreas Kienast uploaded patch set 5 V +1 04/07/25, 13:12

  14. Andreas Kienast marked it ready for review 04/07/25, 13:12

  15. core-ci voted on patch set 5 V +1 04/07/25, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77138

  16. Andreas Kienast voted on patch set 5 CR +2 V +2 04/07/25, 13:20

  17. Andreas Kienast merged patch set 6 04/07/25, 13:20