83839[BUGFIX] Allow persisting nullable properties in extbase
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php8+42 −11
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Post.php+15 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_post.php+9 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xlf+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/TestResultNullableDateTimeProperty.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/TestResultNullableDomainModelRelation.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php+4 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/UpdateTest.php6new+93 −0
Review log 2532
Show 57 earlier messages
-
Torben Hansen uploaded patch set 1 04/16/24, 17:21
-
Torben Hansen updated the commit message in patch set 2 04/16/24, 17:21
-
core-ci voted on patch set 1 V +1 04/16/24, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56097
-
core-ci voted on patch set 2 V +1 04/16/24, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56098
-
Oliver Klee commented on patch set 2 04/16/24, 20:37
If this is a bugfix, would it make sense to backport it to 12.4? -
Mathias Brodala commented on patch set 2 CR -1 04/17/24, 06:22
Backend.php:944We should be careful here to not change the existing method signature. Instead the property should be the 3rd argument. You can use named parameters here to skip the $columnMap if not necessary.Backend.php:950Instead of adjusting a variable you should use early returns everywhere. This also makes the code easier to understand.Backend.php:959This must be a \DateTimeInterface check instead, otherwise subclasses and \DateTimeImmutable are not covered. -
Torben Hansen uploaded patch set 3
CR -1V +104/17/24, 17:01
-
Torben Hansen commented on patch set 2 04/17/24, 17:01
Reply
Basically yes, but I would prefer not to change this in v12 to reduce the risk of unwanted side-effects with the patch.Backend.php:944ReplyDoneBackend.php:950ReplyDoneBackend.php:959ReplyDone -
core-ci voted on patch set 3 V +1 04/17/24, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56186
-
Torben Hansen updated the commit message in patch set 4
V +104/17/24, 17:09 -
core-ci voted on patch set 4 V +1 04/17/24, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56187
-
Oliver Klee commented on patch set 4 04/17/24, 17:16
Reply
Ack. -
Oliver Klee commented on patch set 4 04/17/24, 17:17
UpdateTest.php:40These can all be private. -
Mathias Brodala voted on patch set 4 CR +1 04/18/24, 05:22
-
Georg Ringer voted on patch set 4 CR +1 V +1 04/18/24, 05:31
-
Stefan Bürk commented on patch set 4 CR -1 04/18/24, 13:21
See https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/CodingGuidelines/CodingBestPractices/NamedArguments.html#named-arguments, no use of named arguemnts in TYPO3 code even for calling own api/methodsBackend.php:324We do not use named arguemnts, see -> https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/CodingGuidelines/CodingBestPractices/NamedArguments.html#named-arguments -
Stefan Bürk commented on patch set 4 04/18/24, 13:29
UpdateTest.php:73We usually use `$this->assertCSVDataSet()` for database record assertion in various places, and I would stay away from direct retrievements using querybuilder records that way.UpdateTest.php:102We usually use `$this->assertCSVDataSet()` for database record assertion in various places, and I would stay away from direct retrievements using querybuilder records that way. -
Torben Hansen uploaded patch set 5
CR +1V +104/18/24, 15:23 -
Torben Hansen commented on patch set 4 04/18/24, 15:23
Backend.php:324ReplyDoneUpdateTest.php:40ReplyDoneUpdateTest.php:73ReplyDone -
core-ci voted on patch set 5 V +1 04/18/24, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56268
-
Oliver Klee voted on patch set 5 V +1 04/18/24, 15:38
-
Oliver Klee commented on patch set 5 04/19/24, 17:04
UpdateTest.php:102ReplyDone -
Torben Hansen commented on patch set 5 04/19/24, 17:10
Reply
Done -
Torben Hansen rebased onto patch set 6
V +104/22/24, 12:01 -
core-ci voted on patch set 6 V +1 04/22/24, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56487
-
Oliver Klee voted on patch set 6 V +1 04/22/24, 12:45
-
Torben Hansen rebased onto patch set 7
V +104/27/24, 11:26 -
Oliver Klee voted on patch set 7 V +1 04/27/24, 11:28
-
core-ci voted on patch set 7 V +1 04/27/24, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56847
-
Simon Schaufelberger voted on patch set 7 CR +1 V +1 04/29/24, 09:25
-
Benni Mack voted on patch set 7 CR +2 V +2 05/07/24, 05:32
-
Benni Mack merged patch set 8 05/07/24, 05:32