Review main Merged

83840[TASK] Remove unused variable in DataHandler

Torben Hansen CR +2 V +2 Easy +0 −1 updated 04/19/24, 12:29

Commit message

Initializing the variable `$nativeDateTimeFieldEmptyValue` to
an empty string in the function `checkValueForDatetime` is
superfluous, since the variable is initialized again in the
following if-condition and only used inside the condition
code.

The initialization to an empty string can therefore safely
be removed.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • Jörg Bösche +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Torben Hansen uploaded patch set 1 04/16/24, 17:28

  2. core-ci voted on patch set 1 V +1 04/16/24, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56099

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 04/17/24, 06:59

  4. Andreas Kienast voted on patch set 1 CR +1 04/17/24, 08:10

  5. Andreas Kienast voted on patch set 1 V +1 04/17/24, 08:11

  6. Simon Schaufelberger voted on patch set 1 CR +1 V +1 04/17/24, 12:20

  7. Jörg Bösche voted on patch set 1 CR +1 04/19/24, 12:26

  8. Stefan Bürk voted on patch set 1 CR +2 V +2 04/19/24, 12:29

  9. Stefan Bürk merged patch set 2 04/19/24, 12:29