Review main Merged

83842[BUGFIX] Guard nullable getNormalizedParams in getIpFunction

Nikita Hovratov CR +2 V +2 Easy +5 −1 updated 04/18/24, 06:04

Commit message

In case of CLI context, normalized params are not available and as they
are nullable, a guard condition is required before accessing methods.

Note: The access via request object was added in #100047 along with a
deprecation of using the ip() function in TSConfig. However, there is a
special case, where plain TypoScript is loaded even in CLI context. For
example this can happen when EXT:form listens to FlexForm data structure
parsing event. Then it needs information from TypoScript on how to
manipulate FlexForm based on YAML definitions.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1012

  1. Nikita Hovratov uploaded patch set 1 04/17/24, 08:48

  2. core-ci voted on patch set 1 V +1 04/17/24, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56132

  3. Oliver Klee commented on patch set 1 04/17/24, 09:14

    DefaultFunctionsProvider.php:70

    Would it make sense to put it in a localized variable (e.g., `$normalizedParameters`) to avoid the duplicate method call, and to help static code analysis?
  4. Nikita Hovratov uploaded patch set 2 V +1 04/17/24, 09:19

  5. Nikita Hovratov commented on patch set 2 04/17/24, 09:19

    DefaultFunctionsProvider.php:70 Reply

    Sure thing!
  6. Nikita Hovratov commented on patch set 2 04/17/24, 09:19

    DefaultFunctionsProvider.php:70 Reply

    Done
  7. core-ci voted on patch set 2 V +1 04/17/24, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56134

  8. Oliver Klee voted on patch set 2 CR +1 04/17/24, 09:33

  9. Oli Bartsch voted on patch set 2 CR +1 V +1 04/17/24, 09:53

  10. Christian Kuhn commented on patch set 2 CR +1 V +1 04/17/24, 13:55

    don't like it much, but probably no other solution. i wasn't aware ext:form triggers TS parsing by the FF DS hooks. sucks.
  11. Nikita Hovratov voted on patch set 2 CR +2 V +2 04/18/24, 05:06

  12. Nikita Hovratov merged patch set 3 04/18/24, 06:04