Review main Merged

83843[DOCS] Fix PHP syntax in PageContentPreviewRenderingEvent example

Nikita Hovratov CR +2 V +2 Easy +5 −4 updated 04/17/24, 13:14

Commit message

The $event parameter is now added and a superfluous parenthesis is
removed in the condition. Also, the $tableName variable is used now.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Nikita Hovratov uploaded patch set 1 04/17/24, 09:31

  2. core-ci voted on patch set 1 V +1 04/17/24, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56136

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 04/17/24, 09:49

  4. Andreas Kienast voted on patch set 1 CR +2 V +2 04/17/24, 10:23

  5. Oliver Klee voted on patch set 1 CR +1 V +1 04/17/24, 11:04

  6. Nikita Hovratov merged patch set 2 04/17/24, 13:14