83844[BUGFIX] Check for children in FormEngine container
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Marcin Sągol +1
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Marcin Sągol +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1721
-
Oli Bartsch uploaded patch set 1 04/17/24, 09:41
-
Stefan Bürk voted on patch set 1 CR +1 04/17/24, 09:43
-
core-ci voted on patch set 1 V +1 04/17/24, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56139
-
Marcin Sągol commented on patch set 1 V -1 04/17/24, 09:56
InlineControlContainer.php:142Same here, the `children` is also used in other places in this class so we must handle it there. -
Oli Bartsch uploaded patch set 2
CR +1V +104/17/24, 10:04 -
core-ci voted on patch set 2 V +1 04/17/24, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56145
-
Marcin Sągol commented on patch set 2 CR +1 V +1 04/17/24, 10:14
Works fine. -
Marcin Sągol commented on patch set 2 04/17/24, 10:14
FilesControlContainer.php:149ReplyDoneInlineControlContainer.php:142ReplyDone -
Mathias Brodala commented on patch set 2 04/17/24, 10:48
whileFilesControlContainer.php:156Notice that end() as well as reset() not only return elements of an array but also modify the internal pointer. Since this can lead to obscure errors I'd personally prefer something like this: $firstChild = $inlineChildren[array_key_first($inlineChildren)] ?? null; $lastChild = $inlineChildren[array_key_last($inlineChildren)] ?? null; This ensures that $inlineChildren is definitely left unchanged. -
Oli Bartsch uploaded patch set 3
CR +1V +104/17/24, 19:37 -
Oli Bartsch commented on patch set 3 04/17/24, 19:37
Reply
DoneFilesControlContainer.php:156ReplyDone -
core-ci voted on patch set 3 V +1 04/17/24, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56189
-
Andreas Kienast voted on patch set 3 CR +1 04/18/24, 07:22
-
Marcin Sągol commented on patch set 3 04/18/24, 08:05
InlineControlContainer.php:310Should we use $inlineChildren variable also here since it was initialized and re-used before? -
Oli Bartsch uploaded patch set 4
CR +1V +104/18/24, 08:19 -
Oli Bartsch commented on patch set 4 04/18/24, 08:20
InlineControlContainer.php:310ReplyDone -
Marcin Sągol voted on patch set 4 CR +1 V +1 04/18/24, 08:22
-
core-ci voted on patch set 4 V +1 04/18/24, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56234
-
Stefan Bürk voted on patch set 4 CR +1 V +1 04/19/24, 12:28
-
Oli Bartsch voted on patch set 4 CR +2 V +2 04/19/24, 13:54
-
Oli Bartsch merged patch set 5 04/19/24, 13:54
FilesControlContainer.php:149