Review main Merged

83875[BUGFIX] Better refindex for MM and multi workspaces

Christian Kuhn CR +2 V +2 Easy +16 −6 updated 04/18/24, 13:01

Commit message

Calculation of reference index for workspace relations
has a nasty bug in getListOfActiveWorkspaces(): It
always returns only the first workspace id when
there are multiple.

This isn't good in v12 since it creates broken or
missing index entries with MM. It is worse in v13,
since refactorings of the class use the method
for some additional operations.

The patch fixes the broken helper method.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1218

  1. Christian Kuhn uploaded patch set 1 04/17/24, 13:59

  2. Christian Kuhn updated the commit message in patch set 2 04/17/24, 14:01

  3. Christian Kuhn updated the commit message in patch set 3 04/17/24, 14:01

  4. core-ci voted on patch set 3 V -1 04/17/24, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56174

  5. Christian Kuhn uploaded patch set 4 V -1 04/17/24, 15:35

  6. core-ci voted on patch set 4 V -1 04/17/24, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56185

  7. Christian Kuhn uploaded patch set 5 V -1 04/18/24, 08:50

  8. core-ci voted on patch set 5 V -1 04/18/24, 08:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56241

  9. Christian Kuhn uploaded patch set 6 V -1 04/18/24, 10:49

  10. core-ci voted on patch set 6 V +1 04/18/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56251

  11. Christian Kuhn uploaded patch set 7 V +1 04/18/24, 12:28

  12. Christian Kuhn uploaded patch set 8 04/18/24, 12:29

  13. core-ci voted on patch set 7 V +1 04/18/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56257

  14. Stefan Bürk voted on patch set 8 CR +1 V +1 04/18/24, 12:34

  15. core-ci voted on patch set 8 V +1 04/18/24, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56258

  16. Jasmina Ließmann voted on patch set 8 CR +1 V +1 04/18/24, 13:01

  17. Christian Kuhn voted on patch set 8 CR +2 V +2 04/18/24, 13:01

  18. Christian Kuhn merged patch set 9 04/18/24, 13:01