Review 12.4 Merged

83877[BUGFIX] Have record icons with human readable title

Willi Wehmeier CR +2 V +2 Normal +82 −50 updated 04/19/24, 09:09

Commit message

Add record titles to the record icon alt text. To make
the alt text for record icons helpful, the title and
type of the record is now added to the existing id=x.

To implement this also for the pagetree, the method
BackendUtility::titleAttribForPages() has got a new
parameter to return the value unescaped.
The JsonResponse in the TreeController already
escapes the data and additionally the TemplateResult
from lit also does escaping.

Additionally BackendUtility::getRecordIconAltText() received
a new parameter to make it possible to not escape string values.
This is necessary to prevent values to get double encoded when
used in the fluid context.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 56

  1. Willi Wehmeier uploaded patch set 1 04/17/24, 14:21

  2. core-ci voted on patch set 1 V +1 04/17/24, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56181

  3. Benjamin Franzke voted on patch set 1 CR +1 04/19/24, 09:05

  4. Jasmina Ließmann voted on patch set 1 CR +2 V +2 04/19/24, 09:06

  5. Jasmina Ließmann merged patch set 2 04/19/24, 09:06

  6. Benjamin Franzke voted on patch set 2 V +1 04/19/24, 09:09