Review main Merged

83878[TASK] Avoid managing keywords in IS BE module

Jasmina Ließmann CR +2 V +2 Normal +7 −78 updated 04/18/24, 11:05

Commit message

The "Indexing" indexed_search backend module allows
picking single indexed words and adding them as
keywords a pages 'keywords' field.

This mixes up two different topics: Search and seo.

Good seo administration should be a separate topic that
involves much more than just adding some arbitrary
keyword to a page. Additionally, meta keywords lost quite
a bit of relevance over the years, and it seems odd the
indexed_search BE module takes care of this detail. It
additionally comes with zero additional explanation for
editors, is hidden in detail views of the module, and
removes the index of a page when used, which leads to
unexpected routing within the module.

The patch removes this functionality.

This also fixes an issue when trying to save keywords
for an index that is not a page, but something else
like an image.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 812

  1. Jasmina Ließmann uploaded patch set 1 04/17/24, 14:57

  2. core-ci voted on patch set 1 V -1 04/17/24, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56183

  3. Jasmina Ließmann uploaded patch set 2 V -1 04/17/24, 15:10

  4. core-ci voted on patch set 2 V +1 04/17/24, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56184

  5. Jasmina Ließmann updated the commit message in patch set 3 V +1 04/18/24, 08:59

  6. core-ci voted on patch set 3 V +1 04/18/24, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56245

  7. Christian Kuhn uploaded patch set 4 V +1 04/18/24, 09:35

  8. Christian Kuhn voted on patch set 4 CR +1 04/18/24, 09:36

  9. Christian Kuhn voted on patch set 4 V +1 04/18/24, 09:39

  10. core-ci voted on patch set 4 V +1 04/18/24, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56247

  11. Georg Ringer voted on patch set 4 CR +2 V +2 04/18/24, 11:05

  12. Georg Ringer merged patch set 5 04/18/24, 11:05