Review main Merged

83917[BUGFIX] Correctly purge RelationHandler readMM() relations

Christian Kuhn CR +2 V +2 Normal +188 −20 updated 04/18/24, 12:17

Commit message

Resolving relations in RelationHandler for MM in
workspaces is a two fold process: readMM() first
finds all relation "candidates". A second step
then filters live MM relations from the candidate
list that have a workspace overlay.

In general, it *should* be possible to combine this
rather expensive operation into a single query. This
however requires a bigger rewrite of the class,
which absoletly needs to happen at some point,
especially for performance considerations.

There is however a significant bug the patch aims
to solve now: The result set of MM relations tends
to return relations not only of the workspace-uid
that has been requested, but relations of other
workspaces as well, due to an insufficient query
with improper filter logic in the second part of
the process.

This patch is important for a bug fix within
ReferenceIndex, which - when fixed - triggers
the currently broken RelationHandler relation
calculation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 67

  1. Christian Kuhn uploaded patch set 1 04/18/24, 11:22

  2. core-ci voted on patch set 1 V +1 04/18/24, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56253

  3. Stefan Bürk voted on patch set 1 CR +1 04/18/24, 11:52

  4. Stefan Bürk voted on patch set 1 V +1 04/18/24, 11:58

  5. Jasmina Ließmann voted on patch set 1 CR +1 V +1 04/18/24, 12:15

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 04/18/24, 12:17

  7. Christian Kuhn merged patch set 2 04/18/24, 12:17