Review main Merged

83919[BUGFIX] Fix "No results" positioning in Live Search

Andreas Kienast CR +2 V +2 Easy +7 −0 updated 04/23/24, 04:52

Commit message

The "No results found" alert is rendered in a flex-row container, which
caused a rendering bug where the alert box was stretched to a height of
100%, but its width is limited to its content. Use flex children
modifiers to ensure correct positioning.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Andreas Kienast uploaded patch set 1 04/18/24, 11:54

  2. core-ci voted on patch set 1 V -1 04/18/24, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56255

  3. Andreas Kienast uploaded patch set 2 V -1 04/18/24, 13:11

  4. core-ci voted on patch set 2 V +1 04/18/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56263

  5. Jörg Bösche voted on patch set 2 CR +1 04/19/24, 12:24

  6. Benjamin Franzke uploaded patch set 3 CR +1 V +1 04/22/24, 10:36

  7. Benjamin Franzke voted on patch set 3 CR +1 V +1 04/22/24, 10:36

  8. core-ci voted on patch set 3 V +1 04/22/24, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56483

  9. Andreas Kienast commented on patch set 3 04/22/24, 10:47

    Much better, thanks a ton!
  10. Christian Kuhn voted on patch set 3 CR +1 V +1 04/23/24, 00:03

  11. Andreas Kienast voted on patch set 3 CR +2 V +2 04/23/24, 04:52

  12. Andreas Kienast merged patch set 4 04/23/24, 04:52