Review main Abandoned

83922[BUGFIX] Render correct link to exception documentation

Andreas Kienast CR 0 V 0 Easy +3 −3 updated 04/21/24, 11:55

Commit message

This commit updates the `Typo3Information::URL_EXCEPTION` constant used
as a base path to link to the documentation page of an thrown exception.
Also, the rendering is slightly adjusted as the URLs end with `.html`.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1011

  1. Andreas Kienast uploaded patch set 1 04/18/24, 13:28

  2. Stefan Bürk commented on patch set 1 CR +1 V +1 04/18/24, 13:35

    Backround of other reviewes: The intermediate application on the fly checking / and creating exception code pages has been removed some time ago, not existing exception code pages would get an 404 anyway nowerdays. Exception codes are rendered on casual basis after releases and are created from a template anyway. That reduced systems no-one maintains and knows on the Documentation Team side. Thanks Andreas for taking care of this adjustment to avoid a obsolete redirect.
  3. core-ci voted on patch set 1 V +1 04/18/24, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56265

  4. Chris Müller commented on patch set 1 04/18/24, 13:43

    Notice: We will change the URL in the next weeks. Reasons: it is in the path of the legacy manuals which we want to get rid of. And this manual is currently rendered in a separate action and not available via Intercept - which is a blocker currently for switching to the new rendering.
  5. Andreas Kienast commented on patch set 1 04/18/24, 13:56

    Reply

    What does this mean for the patch? It's a blocker?
  6. Chris Müller commented on patch set 1 04/18/24, 14:14

    Reply

    Nope no blocker (a notice), but the URL will change then again.
  7. Chris Müller commented on patch set 1 04/19/24, 07:59

    Reply

    So, let's get this in. We can use another patch, if the URL has been changed again.
  8. Andreas Kienast commented on patch set 1 CR -2 04/19/24, 13:11

    Waiting for other feedback
  9. Andreas Kienast commented on patch set 1 04/19/24, 13:48

    The original redirects are working again. We can now either ditch the patch or adjust it once the original URLs change again.
  10. Chris Müller commented on patch set 1 04/19/24, 14:47

    Reply

    Actually, I like the redirect. This way, we just have to adjust the location once when it changes - without changing the link in Core for various versions.
  11. Andreas Kienast abandoned the change 04/21/24, 11:55

    Original redirects are functional again.